RE: [PATCH 1/3] Bluetooth: hci_uart: Add PM for BCM2E39

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Loic,

-----Original Message-----
From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-owner@xxxxxxxxxxxxxxx] On Behalf Of Loic Poulain
Sent: Friday, July 17, 2015 9:12 AM
To: Ilya Faenson; Frederic Danis; linux-bluetooth@xxxxxxxxxxxxxxx; Marcel Holtmann
Cc: Arend Van Spriel
Subject: Re: [PATCH 1/3] Bluetooth: hci_uart: Add PM for BCM2E39

Hi Ilya,
> IF: Sorry for the delay in responding. I am not actively working on the similar DT driver at the moment as we have hit a DT maintainer roadblock for its development. I do not read this bulletin board much therefore. Great seeing a first take on the Broadcom BT UART ACPI driver! Looks like a good start to me. A few comments:
>

Most of Bluetooth UART chips have some extra configuration (PCM, I2S, 
LPM...)
with specific vendor commands. Since it looks hard to include this 
information
into DT and much more difficult into ACPI, I suggest to implement a 
common way
to that with a generic btconf file. This file could be retrieved via 
request_firmware
and filled with a list of HCI commands for vendor config. This 
configuration should
happen after firmware download. If no conf file found, you can apply a 
default
configuration or just ignore it.

It's just a proposal, I don't know if it does completely match your 
requirements.

IF: Good ideas, Loic. I personally would not want to see just the vendor specific commands in the configuration. I would want to see parameters which would be up to a specific IHV driver to interpret. How do you configure say a number of idle seconds to wait before suspending via VSC, for example? Certain parameters many contain VSCs if one wishes of course. Free form parameters would be more flexible in my opinion. Firmware file name may be one of them too. Something like an XML file would fit the bill in my opinion. I think Marcel is already working on the device "manifest files". He's mentioned them in a context of the firmware file configuration but I assume it will be expandable. Hope he has a chance to clarify the approach he's taking.

Regards,
Loic

-- 
Intel Open Source Technology Center
http://oss.intel.com/

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
��.n��������+%������w��{.n�����{����^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�

[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux