Re: [PATCH ] AVRCP: Handle Total Number Of Tracks metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bharat,

On Fri, Jun 19, 2015 at 12:45 PM, Bharat Bhusan Panda
<bharat.panda@xxxxxxxxxxx> wrote:
> ping
>
>> -----Original Message-----
>> From: Bharat Bhusan Panda [mailto:bharat.panda@xxxxxxxxxxx]
>> Sent: Thursday, June 11, 2015 11:14 AM
>> To: 'linux-bluetooth@xxxxxxxxxxxxxxx'
>> Cc: 'cpgs@xxxxxxxxxxx'
>> Subject: RE: [PATCH ] AVRCP: Handle Total Number Of Tracks metadata
>>
>> ping
>>
>> > -----Original Message-----
>> > From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-
>> > owner@xxxxxxxxxxxxxxx] On Behalf Of Bharat Panda
>> > Sent: Friday, June 05, 2015 8:44 PM
>> > To: linux-bluetooth@xxxxxxxxxxxxxxx
>> > Cc: cpgs@xxxxxxxxxxx; Bharat Panda
>> > Subject: [PATCH ] AVRCP: Handle Total Number Of Tracks metadata
>> >
>> > Total Number of Tracks was not displayed, coz "Number of Tracks"
>> > was not handled in metadata parser.
>> > ---
>> >  profiles/audio/media.c | 3 +++
>> >  tools/mpris-proxy.c    | 3 +++
>> >  2 files changed, 6 insertions(+)
>> >
>> > diff --git a/profiles/audio/media.c b/profiles/audio/media.c index
>> > f12569e..8e7e1a3 100644
>> > --- a/profiles/audio/media.c
>> > +++ b/profiles/audio/media.c
>> > @@ -1510,6 +1510,9 @@ static gboolean parse_player_metadata(struct
>> > media_player *mp,
>> >             } else if (strcasecmp(key, "xesam:trackNumber") == 0) {
>> >                     if (!parse_int32_metadata(mp, "TrackNumber",
>> > &var))
>> >                             return FALSE;
>> > +           } else if (strcasecmp(key, "xesam:totalTracks") == 0) {
>> > +                   if (!parse_int32_metadata(mp, "NumberOfTracks",
>> > &var))
>> > +                           return FALSE;
>> >             } else
>> >                     DBG("%s not supported, ignoring", key);
>> >
>> > diff --git a/tools/mpris-proxy.c b/tools/mpris-proxy.c index
>> > 693055e..5749427
>> > 100644
>> > --- a/tools/mpris-proxy.c
>> > +++ b/tools/mpris-proxy.c
>> > @@ -1261,6 +1261,9 @@ static int parse_track_entry(DBusMessageIter
>> > *entry, const char *key,
>> >     } else if (strcasecmp(key, "TrackNumber") == 0) {
>> >             if (!parse_int32_metadata(&var, "xesam:trackNumber",
>> > metadata))
>> >                     return -EINVAL;
>> > +   } else if (strcasecmp(key, "NumberOfTracks") == 0) {
>> > +           if (!parse_int32_metadata(&var, "xesam:totalTracks",
>> > metadata))
>> > +                   return -EINVAL;

I remember not finding any documentation for xesam:totalTracks do you
have a link for it? If you could you please add to the description.

>> >     } else if (strcasecmp(key, "Item") == 0) {
>> >             if (!parse_path_metadata(&var, "mpris:trackid", metadata))
>> >                     return -EINVAL;
>> > --
>> > 1.9.1
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe
>> > linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx
>> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux