Re: [PATCH] Bluetooth:hci_bcsp:Fix coding style -- Clean up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Prasanna,

On Fri, Jun 19, 2015, Mutharaju, Prasanna (P.) wrote:
> On Fri, Jun 19, 2015 at 11:20:43AM +0200, Marcel Holtmann wrote:
> > Hi Prasanna,
> > 
> > > Space prohibited between function name and open parenthesis '('
> > > reported by Checkpatch
> > > 
> > > Signed-off-by: Prasanna Karthik <mkarthi3@xxxxxxxxxxx>
> > > ---
> > > drivers/bluetooth/hci_bcsp.c |    8 ++++----
> > > 1 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > I got a malformed patch on my side. I can not apply it with git am.
> > 
> > Regards
> > 
> > Marcel
> > 
> Hey Marcel,
> 
> I see git am applies fine on my branch. Actually, Fix is for Space warning and not 
> intended for lines > 80 chars. Any suggestions ?

No direct suggestions, but there is definitely something wrong with the
patch since I'm unable to apply it as well:

Applying: Bluetooth:hci_bcsp:Fix coding style -- Clean up
/home/jh/src/linux/.git/rebase-apply/patch:25: trailing whitespace.
					bcsp->rx_skb->data[0] & 0x80 ? 
/home/jh/src/linux/.git/rebase-apply/patch:30: space before tab in indent.
			    		&& (bcsp->rx_skb->data[0] & 0x07) != bcsp->rxseq_txack) {
error: patch failed: drivers/bluetooth/hci_bcsp.c:464
error: drivers/bluetooth/hci_bcsp.c: patch does not apply
Patch failed at 0001 Bluetooth:hci_bcsp:Fix coding style -- Clean up

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux