Hi Marcel and Fred, -----Original Message----- From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-owner@xxxxxxxxxxxxxxx] On Behalf Of Marcel Holtmann Sent: Thursday, June 18, 2015 7:49 AM To: Frederic Danis Cc: linux-bluetooth@xxxxxxxxxxxxxxx Subject: Re: [PATCH] Bluetooth: hci_uart: Fix speed selection Hi Fred, > hu->proto->*speed will always be used for all device where it is set. > But hu->*speed should be used if exist, so the test should be swapped. > > The equivalent change is needed in bcm_setup() of hci_bcm.c. > > Signed-off-by: Frederic Danis <frederic.danis@xxxxxxxxxxxxxxx> > --- > drivers/bluetooth/hci_bcm.c | 29 +++++++++++++++++++++++------ > drivers/bluetooth/hci_ldisc.c | 12 ++++++------ > 2 files changed, 29 insertions(+), 12 deletions(-) patch has been applied to bluetooth-next tree. IF: I've just checked the latest hci_ldisc.c speed selection logic against what I submitted yesterday. They are functionally the same so you have my blessing if you need it. :-) Still, having speed configuration in two places is obviously an invitation to some confusion. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
