The add advertisement tests were named a bit inconsistently and the test intent was not always clear from the naming of the test. This has been improved by introducing a somewhat more consistent naming scheme and adding additional hints wrt the test intent. --- tools/mgmt-tester.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c index eda69f7..089812e 100644 --- a/tools/mgmt-tester.c +++ b/tools/mgmt-tester.c @@ -6576,70 +6576,70 @@ int main(int argc, char *argv[]) test_le("Add Advertising - Invalid Params 10 (ScRsp too long)", &add_advertising_fail_11, NULL, test_command_generic); - test_bredrle("Add Advertising - Timeout Not Powered", + test_bredrle("Add Advertising - Rejected (Timeout, !Powered)", &add_advertising_fail_12, NULL, test_command_generic); - test_bredrle("Add Advertising - Timeout Power off", - &add_advertising_power_off, - setup_add_advertising_timeout, - test_command_generic); - test_bredrle("Add Advertising - Success 1", + test_bredrle("Add Advertising - Success 1 (Powered, Add Adv Inst)", &add_advertising_success_1, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 2", + test_bredrle("Add Advertising - Success 2 (!Powered, Add Adv Inst)", &add_advertising_success_2, setup_add_advertising_not_powered, test_command_generic); - test_bredrle("Add Advertising - Success 3", + test_bredrle("Add Advertising - Success 3 (!Powered, Adv Enable)", &add_advertising_success_3, setup_add_advertising_not_powered, test_command_generic); - test_bredrle("Add Advertising - Set Advertising on override 1", + test_bredrle("Add Advertising - Success 4 (Set Adv on override)", &add_advertising_success_4, setup_add_advertising, test_command_generic); - test_bredrle("Add Advertising - Set Advertising off override 2", + test_bredrle("Add Advertising - Success 5 (Set Adv off override)", &add_advertising_success_5, setup_set_and_add_advertising, test_command_generic); - test_bredrle("Add Advertising - Success 4", + test_bredrle("Add Advertising - Success 6 (Scan Rsp Dta, Adv ok)", &add_advertising_success_6, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 5", + test_bredrle("Add Advertising - Success 7 (Scan Rsp Dta, Scan ok) ", &add_advertising_success_7, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 6 - Flag 0", + test_bredrle("Add Advertising - Success 8 (Connectable Flag)", &add_advertising_success_8, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 7 - Flag 1", + test_bredrle("Add Advertising - Success 9 (General Discov Flag)", &add_advertising_success_9, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 8 - Flag 2", + test_bredrle("Add Advertising - Success 10 (Limited Discov Flag)", &add_advertising_success_10, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 8 - Flag 3", + test_bredrle("Add Advertising - Success 11 (Managed Flags)", &add_advertising_success_11, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 9 - Flag 4", + test_bredrle("Add Advertising - Success 12 (TX Power Flag)", &add_advertising_success_12, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 10 - ADV_SCAN_IND", + test_bredrle("Add Advertising - Success 13 (ADV_SCAN_IND)", &add_advertising_success_13, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 11 - ADV_NONCONN_IND", + test_bredrle("Add Advertising - Success 14 (ADV_NONCONN_IND)", &add_advertising_success_14, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 12 - ADV_IND", + test_bredrle("Add Advertising - Success 15 (ADV_IND)", &add_advertising_success_15, NULL, test_command_generic); - test_bredrle("Add Advertising - Success 13 - connectable -> on", + test_bredrle("Add Advertising - Success 16 (Connectable -> on)", &add_advertising_success_16, setup_add_advertising, test_command_generic); - test_bredrle("Add Advertising - Success 14 - connectable -> off", + test_bredrle("Add Advertising - Success 17 (Connectable -> off)", &add_advertising_success_17, setup_add_advertising_connectable, test_command_generic); + test_bredrle("Add Advertising - Success 18 (Power -> off, Remove)", + &add_advertising_power_off, + setup_add_advertising_timeout, + test_command_generic); test_bredrle("Remove Advertising - Invalid Params 1", &remove_advertising_fail_1, -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html