Hi Chan-yeol, > Vendor specific headers should be included only when enabled because > hci_uart does not need it always. > > Signed-off-by: Chan-yeol Park <chanyeol.park@xxxxxxxxxxx> > --- > drivers/bluetooth/hci_ldisc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c > index ac87346..231c622 100644 > --- a/drivers/bluetooth/hci_ldisc.c > +++ b/drivers/bluetooth/hci_ldisc.c > @@ -45,8 +45,12 @@ > #include <net/bluetooth/bluetooth.h> > #include <net/bluetooth/hci_core.h> > > +#ifdef CONFIG_BT_HCIUART_INTEL > #include "btintel.h" > +#endif empty lines here, > +#ifdef CONFIG_BT_HCIUART_BCM > #include "btbcm.h" > +#endif And another empty line here. > #include "hci_uart.h" > However is this really needed? I did not do this since it essentially results into an empty include which will be optimized out. And it just makes the including code more complex. If we worry about the extra structs, then we can just move them down into the IS_ENABLED section into the header itself. I did not worry since my assumption is that compiler optimizes unused structs. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
