Hi Guenter, -----Original Message----- From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-owner@xxxxxxxxxxxxxxx] On Behalf Of Guenter Roeck Sent: Monday, June 15, 2015 10:25 AM To: Marcel Holtmann Cc: linux-kernel@xxxxxxxxxxxxxxx; Frederic Danis; BlueZ development; linux-serial@xxxxxxxxxxxxxxx Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' On 06/15/2015 06:58 AM, Marcel Holtmann wrote: > Hi Guenter, > >> alpha:allmodconfig fails to build in -next with >> >> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate': >> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared >> >> BOTHER is not defined for all architectures and otherwise only >> used with '#ifdef BOTHER'. > > thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures. > So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side. However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes. IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion). Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
