Re: [PATCH] bluetooth: hci_bcsp: Clean up code Fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Prasanna,

> Fix for spaces prohibited around that '->' reported by checkpatch
> and space prohibited between function name and open parenthesis '('
> 
> Signed-off-by: Prasanna Karthik <mkarthi3@xxxxxxxxxxx>
> ---
> drivers/bluetooth/hci_bcsp.c |   28 ++++++++++++++--------------
> 1 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c
> index dc8e3d4..94e0046 100644
> --- a/drivers/bluetooth/hci_bcsp.c
> +++ b/drivers/bluetooth/hci_bcsp.c
> @@ -285,7 +285,7 @@ static struct sk_buff *bcsp_dequeue(struct hci_uart *hu)
> 	struct bcsp_struct *bcsp = hu->priv;
> 	unsigned long flags;
> 	struct sk_buff *skb;
> -	
> +
> 	/* First of all, check for unreliable messages in the queue,
> 	   since they have priority */
> 
> @@ -436,7 +436,7 @@ static inline void bcsp_unslip_one_byte(struct bcsp_struct *bcsp, unsigned char
> 			break;
> 		default:
> 			memcpy(skb_put(bcsp->rx_skb, 1), &byte, 1);
> -			if ((bcsp->rx_skb-> data[0] & 0x40) != 0 && 
> +			if ((bcsp->rx_skb->data[0] & 0x40) != 0 &&
> 					bcsp->rx_state != BCSP_W4_CRC)

if you do this, then also adjust the indentation to follow the network subsystem style. This driver has most likely plenty of them. --strict for checkpatch in case you wonder.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux