Re: [PATCHv2] shared/att: Fix boolean check in handle_notify()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Fri, Jun 5, 2015 at 4:00 PM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@xxxxxxxxx> wrote:
> ping
>
> On Mon, Jun 01, 2015 at 01:11:43PM +0300, Andrei Emeltchenko wrote:
>> ping
>>
>> On Fri, May 29, 2015 at 11:53:26AM +0300, Andrei Emeltchenko wrote:
>> > From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>> >
>> > ext_signed is boolean and shall be checked with logical op.
>> > ---
>> >  src/shared/att.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/src/shared/att.c b/src/shared/att.c
>> > index 053aa47..f9a5817 100644
>> > --- a/src/shared/att.c
>> > +++ b/src/shared/att.c
>> > @@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
>> >     const struct queue_entry *entry;
>> >     bool found;
>> >
>> > -   if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) {
>> > +   if ((opcode & ATT_OP_SIGNED_MASK) && !att->ext_signed) {
>> >             if (!handle_signed(att, opcode, pdu, pdu_len))
>> >                     return;
>> >             pdu_len -= BT_ATT_SIGNATURE_LEN;
>> > --
>> > 2.1.4
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
>> > the body of a message to majordomo@xxxxxxxxxxxxxxx
>> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --

Applied, thanks.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux