Hi Marcel,
>>>> addr can be NULL and it should not be dereferenced before NULL checking.
>>>>
>>>> Signed-off-by: Jaganath Kanakkassery <jaganath.k@xxxxxxxxxxx>
>>>> ---
>> >
>> >if we start changing things here, then we better change the code into something that all the other socket handling code is doing anyway>y. So do the min comparison and copy the data into a local copy of the sockaddr_rc.
>>>
>>> And on a side note, I wonder if addr can actually be NULL. It might be interesting to check the generic socket code if this really can happe>n if you provide no address structure to the bind() system call or if this gets filtered out by the core socket code.
>>
>> I checked generic socket code and it looks like addr will never be NULL when user space calls bind.
>> But this can be called from kernel_bind() also which I think will never be called for RFCOMM.
>> So this patch is not required?
>
>that is what I thought. However converting it to the same handling using min and copying into local storage might be a good idea. The more pieces in HCI, L2CAP, SCO and RFCOMM sockets that are similar, the better.
I have raised v1 with the changes you suggested, Plz check it.
Thanks,
Jaganathÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ý¹nzÚ(¶ âžØ^n‡r¡ö¦zË?ëh™¨èÚ&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~††Ûiÿÿï?êÿ‘êçz_è®æj:+v‰¨þ)ߣøm
