Re: [PATCH] add new device for fixed bug 60901

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Aleksei,

the subject line needs to read "[PATCH] Bluetooth: btusb: " as prefix so we can clearly identify where this belong to. Also stating a random bug number in the subject is useless, refer to the device in question.

> That patch fix bug https://bugzilla.kernel.org/show_bug.cgi?id=60901 for my Roper Class 1 dongle

You need to include the output of /sys/kernel/debug/usb/devices for this specific device in the commit message. I also prefer that instead of just referring to a bug number, you explain why this patch is needed. For example output of hcidump or btmon showing the problem here.

> Signed-off-by: Aleksei Volkov <info@xxxxxxx>
> ---
> drivers/bluetooth/btusb.c | 1+
> 1 file changed, 1 insertion(+), 0 deletion(-)
> 
> diff -up linux-4.0.0-gentoo/drivers/bluetooth/btusb.c.orig linux-4.0.0-gentoo/drivers/bluetooth/btusb.c 
> --- linux-4.0.0/drivers/bluetooth/btusb.c.orig	2015-05-01 12:06:59.000000000 +0300
> +++ linux-4.0.0/drivers/bluetooth/btusb.c	2015-05-01 12:02:00.000000000 +0300
> @@ -254,6 +254,7 @@ static const struct usb_device_id blackl
> 
> 	/* Roper Class 1 Bluetooth Dongle (Silicon Wave based) */
> 	{ USB_DEVICE(0x1300, 0x0001), .driver_info = BTUSB_SWAVE },
> +	{ USB_DEVICE(0x1310, 0x0001), .driver_info = BTUSB_SWAVE },

Did I wrong used 0x1300 originally and meant actually 0x1310 or does Roper really have two USB Vendor IDs this close to each other?

> 	/* Digianswer devices */
> 	{ USB_DEVICE(0x08fd, 0x0001), .driver_info = BTUSB_DIGIANSWER },

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux