Hi Jakub, On Thu, Apr 23, 2015 at 10:58 PM, Jakub Pawlowski <jpawlowski@xxxxxxxxxx> wrote: > On Thu, Apr 23, 2015 at 12:50 PM, Luiz Augusto von Dentz > <luiz.dentz@xxxxxxxxx> wrote: >> Hi Jakub, >> >> On Thu, Apr 23, 2015 at 6:56 PM, Jakub Pawlowski <jpawlowski@xxxxxxxxxx> wrote: >>> Ping ? >> >> Sorry, I forgot about this one. >> >>> On Mon, Apr 20, 2015 at 8:55 AM, Jakub Pawlowski <jpawlowski@xxxxxxxxxx> wrote: >>>> Hi Luiz >>>> >>>> On Mon, Apr 20, 2015 at 7:32 AM, Luiz Augusto von Dentz >>>> <luiz.dentz@xxxxxxxxx> wrote: >>>>> Hi Jakub, >>>>> >>>>> On Sat, Apr 18, 2015 at 4:09 AM, Jakub Pawlowski <jpawlowski@xxxxxxxxxx> wrote: >>>>>> This adds TxPower from advertisement data. >>>>>> >>>>>> Signed-off-by: Jakub Pawlowski <jpawlowski@xxxxxxxxxx> >>>>>> --- >>>>>> doc/device-api.txt | 5 +++++ >>>>>> 1 file changed, 5 insertions(+) >>>>>> >>>>>> diff --git a/doc/device-api.txt b/doc/device-api.txt >>>>>> index 72c597e..875fd9d 100644 >>>>>> --- a/doc/device-api.txt >>>>>> +++ b/doc/device-api.txt >>>>>> @@ -196,6 +196,11 @@ Properties string Address [readonly] >>>>>> Received Signal Strength Indicator of the remote >>>>>> device (inquiry or advertising). >>>>>> >>>>>> + int16 TxPower [readonly, optional] >>>>>> + >>>>>> + Advertised transmitted power level (inquiry or >>>>>> + advertising). >>>>>> + >>>>>> dict ManufacturerData [readonly, optional] >>>>>> >>>>>> Manufacturer specific advertisement data. Keys are >>>>>> -- >>>>>> 2.2.0.rc0.207.ga3a616c >>>>> >>>>> I thought we discussed about this before and we would like to have the >>>>> pathloss instead of TxPower, or do you have something else useful for >>>>> TxPower? >>>> >>>> I don't remember such discussion, I remember we were discussing about >>>> SetDiscoveryFilter, and it have option to filter by pathloss. >>>> So I exposed TxPower for two reasons: >>>> 1. It's just a field in advertisement, and I wanted just to access it >>>> as any other. >>>> 2. If I turn it into Pathloss field, it would change together with >>>> RSSI, and PropertyChanged event will be doubled. Pathloss is very >>>> simple to compute, so having only RSSI that change is more efficient. >> >> Fair enough, I just notice I did not mark the these properties as >> experimental in the documentation, but no need to send another version >> I will fix it when applying your patches. > > Ok, Thanks! Applied after removing Signed-off-by line as well as fixing the missing experimental flag, thanks. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
