Re: [PATCH BlueZ] core/gatt-database: Fix endless loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Apr 13, 2015 at 3:10 PM, Luiz Augusto von Dentz
<luiz.dentz@xxxxxxxxx> wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>
> The descriptors list may contain descriptors from another services which
> should be ignored but the code did not iterate to next item causing an
> endless loop if that happen.
> ---
>  src/gatt-database.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gatt-database.c b/src/gatt-database.c
> index bbeb7cd..f182fd0 100644
> --- a/src/gatt-database.c
> +++ b/src/gatt-database.c
> @@ -1964,7 +1964,7 @@ static bool database_add_chrc(struct external_service *service,
>                 struct external_desc *desc = entry->data;
>
>                 if (desc->handled || g_strcmp0(desc->chrc_path, chrc->path))
> -                       continue;
> +                       goto next;
>
>                 if (!database_add_desc(service, desc)) {
>                         chrc->attrib = NULL;
> @@ -1972,6 +1972,7 @@ static bool database_add_chrc(struct external_service *service,
>                         return false;
>                 }
>
> +next:
>                 entry = entry->next;
>         }
>
> --
> 2.1.0

Applied.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux