Re: [PATCHv2 04/27] android/hog: Remove tracking gatt operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luiz

On 2015-04-07 09:50, Luiz Augusto von Dentz wrote:
Hi Mariusz,

On Fri, Apr 3, 2015 at 4:43 PM, Mariusz Skamra <mariusz.skamra@xxxxxxxxx> wrote:
Since the use of bt_gatt_client there is no need to queue pending gatt
operations. bt_gatt_client already keeps track on that, so that
on bt_gatt_client_unref the queue of pending requests is destroyed.

This assumption that unref will properly cancel the pending request is
not correct, it will only do what you are saying if it is the last
reference so we still need to track the requests and properly cancel
them since we have no idea how many references of bt_gatt_client
exists.

Thanks for that. I will remove this patch from hog as well as other profiles (scpp, dis, bas). I already discussed that with Szymon, and my intention was to delete all the requests after the last gatt_client dereference (just like you wrote). I assumed that if we want to disconnect/remove device, all the pending requests, no matter of which gatt based service will be removed.

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux