Re: [PATCH v5 0/7] Bluetooth: New callback type for HCI requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johan,

> v5: rebased (and tested) against latest bluetooth-next.git
> v4: rebased (and tested) against latest bluetooth-next.git
> v3: Make skb callback consistent with hci_cmd_sync_ev() semantics
> v2: rebased (and tested) against latest bluetooth-next.git
> 
> Original cover letter:
> 
> This patch set adds a new callback type for HCI requests which allows
> passing the resulting command completion skb to the callback for further
> parsing. The set also converts the first two users for this new API,
> namely the synchronous requests as well as reading local OOB data.
> 
> The tricky part with passing the skb was the fact that typically HCI
> request callbacks are done after all other hci_event.c processing, while
> the skb we want to pass to the callback should be in pristine form (i.e.
> no skb_pull() or other modifications that hci_event.c handlers may do).
> To solve this the patches create a prestine copy of the skb with
> skb_clone() in the beginning of hci_event_packet() and move the callback
> access to a single place at the end of this function.
> 
> Johan
> 
> ----------------------------------------------------------------
> Johan Hedberg (7):
>      Bluetooth: Add clarifying comment to command status handling
>      Bluetooth: Add second hci_request callback option for full skb
>      Bluetooth: Convert hci_req_sync family of function to new request API
>      Bluetooth: Remove unneeded recv_event variable
>      Bluetooth: Remove unused hci_req_pending() function
>      Bluetooth: Move hci_get_cmd_complete() to hci_event.c
>      Bluetooth: Convert local OOB data reading to use HCI request
> 
> include/net/bluetooth/bluetooth.h |   3 +
> include/net/bluetooth/hci_core.h  |   7 +-
> net/bluetooth/hci_core.c          | 114 +++++++--------------------
> net/bluetooth/hci_event.c         | 150 +++++++++++++++++++++++++-----------
> net/bluetooth/hci_request.c       |  14 +++-
> net/bluetooth/hci_request.h       |   5 +-
> net/bluetooth/mgmt.c              | 105 +++++++++++++++----------
> 7 files changed, 220 insertions(+), 178 deletions(-)

all 7 patches have been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux