Hi Luiz, Am 01.04.2015 um 14:08 schrieb Luiz Augusto von Dentz: > This is actually a fault in our code that the test uncovered which is > good but we failed to see it happening, I actually have some plans to Ok. Then it's good that the openSUSE Buildservice setup has these parameters set as default for building :-) > have a check-valgrind target to catch this type of problems or maybe > there is a way to add MALLOC_CHECK_=3 MALLOC_PERTURB_=69 directly. I can help with that, see attached patch (sorry for the attachment, but making thunderbird behave well is out of scope for now :-) Best regards, Stefan -- Stefan Seyfried Linux Consultant & Developer -- GPG Key: 0x731B665B B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537
>From f76391a35bd168a31d62ab0ea16dfdc3bdeb52e1 Mon Sep 17 00:00:00 2001 From: Stefan Seyfried <seife+dev@xxxxxxxxxxxxxx> Date: Wed, 1 Apr 2015 22:04:41 +0200 Subject: [PATCH] enable glibc's malloc checks for the test suite Setting MALLOC_CHECK_=3 causes additional checks in glibc for malloc() usage errors, abort()ing the test if those trigger. MALLOC_PERTURB_=69 causes free()'d memory to be poisoned with 0x45, leading to crashes in case of use-after-free. Together, both are useful for spotting more errors during "make check" Signed-off-by: Stefan Seyfried <seife+dev@xxxxxxxxxxxxxx> --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 2255ce8..b6beb42 100644 --- a/Makefile.am +++ b/Makefile.am @@ -413,6 +413,7 @@ noinst_PROGRAMS += $(unit_tests) endif TESTS = $(unit_tests) +AM_TESTS_ENVIRONMENT = MALLOC_CHECK_=3 MALLOC_PERTURB_=69 pkgconfigdir = $(libdir)/pkgconfig -- 2.3.3
