Re: header change affects c++ projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michael,

On Sun, Mar 29, 2015 at 11:34 AM, Michael Cronenworth <mike@xxxxxxxxxx> wrote:
> Hello,
>
> The move of "bswap_128()" in commit 232015aeefd1c945ccfaf9744e791c5888eafcf7
> breaks C++ projects. Specifically: The bswap_128() function is, without a
> cast, assigning a void* to a uint8_t*.

It will probably get applied, no reason to get neurotic on the weekend
no one said we would not take it, so please be patience.

> Can someone please review this commit? The message claims it is a "fix" but
> all I see is code copy and pasted along with a precision loss from uint128_t
> to uint8_t.

It is a fix to uuid: Add bt_uuid_to_le since the convention is to
define 128 bit UUIDs as big endian which then need to be swaped
regardless of endianess.

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux