Re: [PATCH] lib: Fix compilation error in C++ due to inline function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Richard,

On Tuesday 24 of March 2015 14:52:24 Richard Palethorpe wrote:
> This adds explicit typecasts to an inline function to make it C++
> compatible. ---
>  lib/bluetooth.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/bluetooth.h b/lib/bluetooth.h
> index 6ca64b6..ab24443 100644
> --- a/lib/bluetooth.h
> +++ b/lib/bluetooth.h
> @@ -345,8 +345,8 @@ typedef struct {
> 
>  static inline void bswap_128(const void *src, void *dst)
>  {
> -	const uint8_t *s = src;
> -	uint8_t *d = dst;
> +	const uint8_t *s = (const uint8_t *)src;
> +	uint8_t *d = (uint8_t *)dst;
>  	int i;

Just a nitpick: there should be space after cast
(see M5 in doc/coding-style.txt).

>  	for (i = 0; i < 16; i++)

Other than that patch looks good to me.

-- 
BR
Szymon Janc
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux