Hi Arman,
> This patch updates the "supported_flags" parameter returned from the
> "Read Advertising Features" command.
>
> Signed-off-by: Arman Uguray <armansito@xxxxxxxxxxxx>
> ---
> net/bluetooth/mgmt.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 8795037..a4a0d6b 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -6530,6 +6530,7 @@ static int read_adv_features(struct sock *sk, struct hci_dev *hdev,
> size_t rp_len;
> int err;
> bool instance;
> + u32 supported_flags;
>
> BT_DBG("%s", hdev->name);
>
> @@ -6550,7 +6551,13 @@ static int read_adv_features(struct sock *sk, struct hci_dev *hdev,
> return -ENOMEM;
> }
>
> - rp->supported_flags = cpu_to_le32(0);
> + supported_flags = MGMT_ADV_FLAG_CONNECTABLE;
> + supported_flags |= MGMT_ADV_FLAG_DISCOV;
> + supported_flags |= MGMT_ADV_FLAG_LIMITED_DISCOV;
> + supported_flags |= MGMT_ADV_FLAG_MANAGED_FLAGS;
> + supported_flags |= MGMT_ADV_FLAG_TX_POWER;
> +
supported_flags = MGMT_foo |
MGMT_bar;
I would prefer we do it this way.
> + rp->supported_flags = cpu_to_le32(supported_flags);
> rp->max_adv_data_len = HCI_MAX_AD_LENGTH;
> rp->max_scan_rsp_len = HCI_MAX_AD_LENGTH;
> rp->max_instances = 1;
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
