[PATCH v4 1/7] profiles/network: Fix sending error in bnep server add

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



If bnep server add will not proceed successfully, approperiate error
should be returned. Now it returns error if control message send will
fail.
---
 profiles/network/bnep.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/profiles/network/bnep.c b/profiles/network/bnep.c
index adddc33..48926b4 100644
--- a/profiles/network/bnep.c
+++ b/profiles/network/bnep.c
@@ -650,6 +650,7 @@ int bnep_server_add(int sk, char *bridge, char *iface, const bdaddr_t *addr,
 	/* Processing BNEP_SETUP_CONNECTION_REQUEST_MSG */
 	rsp = bnep_setup_decode(sk, req, &dst);
 	if (rsp != BNEP_SUCCESS) {
+		err = -rsp;
 		error("bnep: error while decoding setup connection request: %d",
 									rsp);
 		goto reply;
@@ -673,10 +674,11 @@ int bnep_server_add(int sk, char *bridge, char *iface, const bdaddr_t *addr,
 		rsp = BNEP_CONN_NOT_ALLOWED;
 
 reply:
-	err = bnep_send_ctrl_rsp(sk, BNEP_SETUP_CONN_RSP, rsp);
-	if (err < 0)
+	if (bnep_send_ctrl_rsp(sk, BNEP_SETUP_CONN_RSP, rsp) < 0) {
 		error("bnep: send ctrl rsp error: %s (%d)", strerror(errno),
 									errno);
+		err = -errno;
+	}
 
 	return err;
 }
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux