Hi Luiz,
>>> On Tue, Mar 10, 2015 at 6:31 AM, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote:
>>> From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
>>>
>>> This checks if crypto is enabled and in case it is not do not run test
>>> /TP/GAW/CL/BV-02-C.
>>> ---
>>> unit/test-gatt.c | 12 ++++++++++--
>>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/unit/test-gatt.c b/unit/test-gatt.c
>>> index 2edcacb..7668e93 100644
>>> --- a/unit/test-gatt.c
>>> +++ b/unit/test-gatt.c
>>> @@ -304,9 +304,12 @@ static gboolean context_quit(gpointer user_data)
>>> if (step && step->post_func)
>>> step->post_func(context);
>>>
>>> - destroy_context(context);
>>> + if (context->data->pdu_list[context->pdu_offset].valid)
>>> + tester_test_abort();
>>> + else
>>> + tester_test_passed();
>>>
>>> - tester_test_passed();
>>> + destroy_context(context);
>>>
>>> return FALSE;
>>> }
>>> @@ -910,6 +913,11 @@ static void test_signed_write(struct context *context)
>>> uint8_t key[16] = {0xD8, 0x51, 0x59, 0x48, 0x45, 0x1F, 0xEA, 0x32, 0x0D,
>>> 0xC0, 0x5A, 0x2E, 0x88, 0x30, 0x81, 0x88 };
>>>
>>> + if (!bt_att_has_crypto(context->att)) {
>>
>> Should we assert in this case that
>> bt_gatt_client_write_without_response, given true for "signed_write"
>> returns 0 without crashing? We would at least be validating the
>> current behavior, or perhaps we should add a separate test case for
>> it.
>
> What do you mean, note that this won't affect the test for seclevel
> which test the same code except the signature since the transport is
> considered secure already, all it does it check if crypto has been
> enabled and the make the test no run in such case since it would
> obviously fail. We might have to remove the use of assert in future
> and leave tester_run return the proper result at the end.
the tester.c code is designed to run all test cases no matter what and give you a summary. Using abort is a bad idea in these cases. If you abort, the summary is pointless. It is then either all pass or abort in the middle.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
