Re: [PATCH v4 2/3] Bluetooth: Refactor service discovery filter logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jakub,

On Tue, Mar 03, 2015, Jakub Pawlowski wrote:
> This patch refactor code responsible for filtering when service
> discovery method is used.
> 
> Signed-off-by: Jakub Pawlowski <jpawlowski@xxxxxxxxxx>
> ---
>  net/bluetooth/mgmt.c | 95 ++++++++++++++--------------------------------------
>  1 file changed, 26 insertions(+), 69 deletions(-)

One thing I forgot to mention: please add some more meat to the bones
for this commit message. It's particularly important that you describe
*why* the patch is good. Anyone can with a bit of reading see that the
patch does some refactoring, but the reasoning for doing it it not quite
as clear (and will be even less so if we or anyone else looks at the
commit history 1+ years in the future).

The same applies for any other commit message where you feel you could
improve with these details.

Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux