Hi Gregory,
> Add ratelimited versions of the BT_{INFO,ERR,DBG} printk macros.
>
> The assymetry with the existing _INFO and _ERR macros is because,
> afaics, those are special-cased as an object-file-size optimization.
> Duplicating that for the _RATELIMITED versions would clearly be a
> deoptimization until they got a few more consumers (currently only a
> single consumer is planned).
>
> Signed-off-by: Gregory M. Turner <gmt@xxxxxxxxxxx>
> ---
> include/net/bluetooth/bluetooth.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
> index e00455a..ec321f9 100644
> --- a/include/net/bluetooth/bluetooth.h
> +++ b/include/net/bluetooth/bluetooth.h
> @@ -124,9 +124,12 @@ void bt_info(const char *fmt, ...);
> __printf(1, 2)
> void bt_err(const char *fmt, ...);
>
> -#define BT_INFO(fmt, ...) bt_info(fmt "\n", ##__VA_ARGS__)
> -#define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
> -#define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)
> +#define BT_INFO(fmt, ...) bt_info(fmt "\n", ##__VA_ARGS__)
> +#define BT_INFO_RATELIMITED(fmt, ...) pr_info_ratelimited(fmt "\n", ##__VA_ARGS__)
> +#define BT_ERR(fmt, ...) bt_err(fmt "\n", ##__VA_ARGS__)
> +#define BT_ERR_RATELIMITED(fmt, ...) pr_err_ratelimited(fmt "\n", ##__VA_ARGS__)
> +#define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)
> +#define BT_DBG_RATELIMITED(fmt, ...) pr_debug_ratelimited(fmt "\n", ##__VA_ARGS__)
I would prefer that you only introduce BT_ERR_RATELIMITED and we leave it at that. Since that is the only one we need anyway. And please do not re-indent the existing ones. Just keep them as they are.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
