Re: [PATCH 1/4] unit/test-gatt: Revert GATT server write TC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gowtham,

On Mon, Mar 2, 2015 at 9:00 AM, Gowtham Anandha Babu
<gowtham.ab@xxxxxxxxxxx> wrote:
> This patch reverts the following commits:
> fdca0c1dc9022b92bf7f621f00503fb161b337ee
> 7b8f5250b71e36052e0adeb3a32aa9f51f26e928
> d00d1fa59c87eeb7086cbdadfe7eb99c124b8816.
>
> The GATT server test cases are supposed to tested
> against ts_small_db and ts_large_db_1.
> ---
>  unit/test-gatt.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/unit/test-gatt.c b/unit/test-gatt.c
> index 69654f1..df74122 100644
> --- a/unit/test-gatt.c
> +++ b/unit/test-gatt.c
> @@ -1101,8 +1101,7 @@ static struct gatt_db *make_service_data_1_db(void)
>                                                                 "Device Name"),
>                 PRIMARY_SERVICE(0x0005, HEART_RATE_UUID, 4),
>                 CHARACTERISTIC_STR(GATT_CHARAC_MANUFACTURER_NAME_STRING,
> -                                               BT_ATT_PERM_READ |
> -                                               BT_ATT_PERM_WRITE,
> +                                               BT_ATT_PERM_READ,
>                                                 BT_GATT_CHRC_PROP_READ |
>                                                 BT_GATT_CHRC_PROP_WRITE, ""),
>                 DESCRIPTOR_STR(GATT_CHARAC_USER_DESC_UUID, BT_ATT_PERM_READ,
> @@ -3051,23 +3050,5 @@ int main(int argc, char *argv[])
>                         raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
>                         raw_pdu(0x01, 0x12, 0x07, 0x00, 0x0c));
>
> -       define_test_server("/TP/GAW/SR/BV-03-C", test_server,
> -                       service_db_1, NULL,
> -                       raw_pdu(0x03, 0x00, 0x02),
> -                       raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
> -                       raw_pdu(0x13));
> -
> -       define_test_server("/TP/GAW/SR/BI-02-C", test_server,
> -                       service_db_1, NULL,
> -                       raw_pdu(0x03, 0x00, 0x02),
> -                       raw_pdu(0x12, 0x00, 0x00, 0x01, 0x02, 0x03),
> -                       raw_pdu(0x01, 0x12, 0x00, 0x00, 0x01));
> -
> -       define_test_server("/TP/GAW/SR/BI-03-C", test_server,
> -                       service_db_1, NULL,
> -                       raw_pdu(0x03, 0x00, 0x02),
> -                       raw_pdu(0x12, 0x03, 0x00, 0x01, 0x02, 0x03),
> -                       raw_pdu(0x01, 0x12, 0x03, 0x00, 0x03));
> -
>         return tester_run();
>  }
> --
> 1.9.1

I prefer that you fix the tests instead of reverting and adding them back.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux