Hi Szymon, On Fri, Feb 27, 2015 at 5:27 PM, Szymon Janc <szymon.janc@xxxxxxxxx> wrote: > Hi Michael, > > On Friday 27 of February 2015 07:21:51 Michael Janssen wrote: >> Hi Szymon, >> >> On Fri, Feb 27, 2015 at 7:01 AM, Szymon Janc <szymon.janc@xxxxxxxxx> wrote: >> > If local key wasn't set by bt_att_set_local_key() assume that signing >> > is done by bt_att_send() caller ie. gattrib code. >> > --- >> > src/shared/att.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/src/shared/att.c b/src/shared/att.c >> > index 9787377..b20af21 100644 >> > --- a/src/shared/att.c >> > +++ b/src/shared/att.c >> > @@ -308,7 +308,7 @@ static bool encode_pdu(struct bt_att *att, struct att_send_op *op, >> > >> > sign = att->local_sign; >> > if (!sign) >> > - goto fail; >> > + true; >> >> This should be 'return true;' I think? > > Good catch. I've got this right locally but forgot to amend before generating > patch :) Yep, but as discussed in the IRC there are more problems with it because we increase the data length before this, I guess we are doing to need some refactoring to fix this properly. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
