Re: [PATCH 1/4] audio/avdtp: Remove start timer on stream_free()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

On Thu, Feb 26, 2015 at 5:20 PM, Andrei Emeltchenko
<Andrei.Emeltchenko.news@xxxxxxxxx> wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>
> Makes code identical to android/avdtp
> ---
>  profiles/audio/avdtp.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
> index 896f101..15b611f 100644
> --- a/profiles/audio/avdtp.c
> +++ b/profiles/audio/avdtp.c
> @@ -717,6 +717,9 @@ static void stream_free(void *data)
>         if (stream->timer)
>                 g_source_remove(stream->timer);
>
> +       if (stream->start_timer > 0)
> +               g_source_remove(stream->start_timer);
> +
>         if (stream->io)
>                 close_stream(stream);
>
> --
> 2.1.0

I will take a at this over the weekend, I hope I can make the move
without having to redo the patches otherwise the git history will be
lost e.g:

    android/AVDTP: Fix not removing start_timer source

    It is possible that stream->start_timer can be set on stream_free which
    should then should take care of remove it properly otherwise it can
    trigger which would very likely cause a crash.

    Thanks to Hannu Mallat <hannu.mallat@xxxxxxxxx> for reporting it.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux