get_service_id method is used only within connection code to get id (16
bit value) of received string format 128bit uuid or service named e.g.
panu, gn or nap. There is no need to make it public as bnep.c only
related code.
---
profiles/network/bnep.c | 25 -------------------------
profiles/network/bnep.h | 1 -
profiles/network/connection.c | 20 ++++++++++++++------
3 files changed, 14 insertions(+), 32 deletions(-)
diff --git a/profiles/network/bnep.c b/profiles/network/bnep.c
index 132dbab..d784427 100644
--- a/profiles/network/bnep.c
+++ b/profiles/network/bnep.c
@@ -85,31 +85,6 @@ struct bnep {
void *disconn_data;
};
-uint16_t bnep_service_id(const char *svc)
-{
- int i;
- uint16_t id;
-
- /* Friendly service name */
- for (i = 0; __svc[i].name; i++) {
- if (!strcasecmp(svc, __svc[i].name))
- return __svc[i].id;
- }
-
- /* UUID 128 string */
- for (i = 0; __svc[i].uuid128; i++) {
- if (!strcasecmp(svc, __svc[i].uuid128))
- return __svc[i].id;
- }
-
- /* Try convert to HEX */
- id = strtol(svc, NULL, 16);
- if ((id < BNEP_SVC_PANU) || (id > BNEP_SVC_GN))
- return 0;
-
- return id;
-}
-
const char *bnep_uuid(uint16_t id)
{
int i;
diff --git a/profiles/network/bnep.h b/profiles/network/bnep.h
index 36ad904..0c1669c 100644
--- a/profiles/network/bnep.h
+++ b/profiles/network/bnep.h
@@ -26,7 +26,6 @@ struct bnep;
int bnep_init(void);
int bnep_cleanup(void);
-uint16_t bnep_service_id(const char *svc);
const char *bnep_uuid(uint16_t id);
const char *bnep_name(uint16_t id);
diff --git a/profiles/network/connection.c b/profiles/network/connection.c
index 19a0d8d..cbcf39b 100644
--- a/profiles/network/connection.c
+++ b/profiles/network/connection.c
@@ -46,6 +46,7 @@
#include "src/profile.h"
#include "src/service.h"
#include "src/error.h"
+#include "lib/uuid.h"
#include "bnep.h"
#include "connection.h"
@@ -78,9 +79,16 @@ struct network_conn {
static GSList *peers = NULL;
-static uint16_t get_service_id(struct btd_service *srv)
+static uint16_t get_pan_srv_id(const char *svc)
{
- return bnep_service_id(btd_service_get_profile(srv)->remote_uuid);
+ if (!strcasecmp(svc, "panu") || !strcasecmp(svc, PANU_UUID))
+ return BNEP_SVC_PANU;
+ if (!strcasecmp(svc, "nap") || !strcasecmp(svc, NAP_UUID))
+ return BNEP_SVC_NAP;
+ if (!strcasecmp(svc, "gn") || !strcasecmp(svc, GN_UUID))
+ return BNEP_SVC_GN;
+
+ return 0;
}
static struct network_peer *find_peer(GSList *list, struct btd_device *device)
@@ -283,7 +291,7 @@ static DBusMessage *local_connect(DBusConnection *conn,
DBUS_TYPE_INVALID) == FALSE)
return btd_error_invalid_args(msg);
- id = bnep_service_id(svc);
+ id = get_pan_srv_id(svc);
uuid = bnep_uuid(id);
if (uuid == NULL)
@@ -312,7 +320,7 @@ int connection_connect(struct btd_service *srv)
{
struct network_conn *nc = btd_service_get_user_data(srv);
struct network_peer *peer = nc->peer;
- uint16_t id = get_service_id(srv);
+ uint16_t id = get_pan_srv_id(btd_service_get_profile(srv)->remote_uuid);
GError *err = NULL;
const bdaddr_t *src;
const bdaddr_t *dst;
@@ -501,7 +509,7 @@ void connection_unregister(struct btd_service *srv)
struct btd_device *device = btd_service_get_device(srv);
struct network_conn *conn = btd_service_get_user_data(srv);
struct network_peer *peer = conn->peer;
- uint16_t id = get_service_id(srv);
+ uint16_t id = get_pan_srv_id(btd_service_get_profile(srv)->remote_uuid);
DBG("%s id %u", device_get_path(device), id);
@@ -548,7 +556,7 @@ int connection_register(struct btd_service *srv)
struct btd_device *device = btd_service_get_device(srv);
struct network_peer *peer;
struct network_conn *nc;
- uint16_t id = get_service_id(srv);
+ uint16_t id = get_pan_srv_id(btd_service_get_profile(srv)->remote_uuid);
DBG("%s id %u", device_get_path(device), id);
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
