On Monday 23 February 2015 13:18:39 Marcel Holtmann wrote:
> So I am fine adding a patch that rate limits it.
While I'm at it, I'd might as well go whole-hog and implement
BT_*_RATELIMITED, no? Since, obviously, 50 lines of elegant 90% untested code
is way better than two lines of ugly 100% tested code* :)
To that end, I notice bt_{err,info} are exports in lib.c, while the rest are
macros. I'm trying to determine how tragic and/or useful it would be if those
symbols proliferated into bt_{err,info}{,_ratelimited}.
"git blame" suggests they are object-file-size optimizations and therefore,
there is probably no good reason not to just make them macros -- since there
will only be the single consumer.
Any objections out there?
-
* Just kidding, sort of -- I'd at least make sure they work, by means of some
ugly offline experiment.
-gmt
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
