Re: [PATCH v2 1/3] android/gatt: Fix, add return check for queue push

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Łukasz,

On Monday 16 of February 2015 13:36:43 Lukasz Rymanowski wrote:
> ---
>  android/gatt.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/android/gatt.c b/android/gatt.c
> index 6db2d9f..f3a4e89 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -6257,7 +6257,12 @@ static void find_by_type_request_cb(struct
> gatt_db_attribute *attrib, memcpy(request_data->filter_value,
> find_data->search_value,
>  							find_data->search_vlen);
> 
> -	queue_push_tail(find_data->device->pending_requests, request_data);
> +	if (!queue_push_tail(find_data->device->pending_requests,
> +							request_data)) {
> +		destroy_pending_request(request_data);
> +		find_data->error = ATT_ECODE_INSUFF_RESOURCES;
> +		return;
> +	}
>  }
> 
>  static uint8_t find_by_type_request(const uint8_t *cmd, uint16_t cmd_len,

All patches applied, thanks. (I removed redundant return in 1st patch)

-- 
BR
Szymon Janc
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux