Re: [PATCH 01/11] unit/test-gatt: Fix invalid handle test case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gowtham,

On Wed, Feb 18, 2015 at 1:09 PM, Gowtham Anandha Babu
<gowtham.ab@xxxxxxxxxxx> wrote:
> The main aim of TC TP/GAR/CL/BI-14-C is to check the handle validity.
> So, the requested handle in the pdu should be invalid (0x0000).
> ---
>  unit/test-gatt.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/unit/test-gatt.c b/unit/test-gatt.c
> index 441cf34..2fc0595 100644
> --- a/unit/test-gatt.c
> +++ b/unit/test-gatt.c
> @@ -1591,7 +1591,7 @@ static const struct test_step test_long_read_4 = {
>  };
>
>  static const struct test_step test_long_read_5 = {
> -       .handle = 0x0003,
> +       .handle = 0x0000,
>         .func = test_long_read,
>         .expected_att_ecode = 0x01
>  };
> @@ -2415,8 +2415,8 @@ int main(int argc, char *argv[])
>         define_test_client("/TP/GAR/CL/BI-14-C", test_client, service_db_1,
>                         &test_long_read_5,
>                         SERVICE_DATA_1_PDUS,
> -                       raw_pdu(0x0c, 0x03, 0x00, 0x00, 0x00),
> -                       raw_pdu(0x01, 0x0c, 0x03, 0x00, 0x01));
> +                       raw_pdu(0x0c, 0x00, 0x00, 0x00, 0x00),
> +                       raw_pdu(0x01, 0x0c, 0x00, 0x00, 0x01));
>
>         define_test_client("/TP/GAR/CL/BI-15-C", test_client, service_db_1,
>                         &test_long_read_6,
> --
> 1.9.1

Applied, I had to fix the messages to be within 72 columns, but
otherwise these nice and clean patches so thanks.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux