Hi Johan, On Fri, Feb 13, 2015 at 1:33 PM, Johan Hedberg <johan.hedberg@xxxxxxxxx> wrote: > Hi, > > On Fri, Feb 06, 2015, Gowtham Anandha Babu wrote: >> --- a/src/shared/gatt-helpers.h >> +++ b/src/shared/gatt-helpers.h >> @@ -105,3 +105,5 @@ bool bt_gatt_read_by_type(struct bt_att *att, uint16_t start, uint16_t end, >> bt_gatt_discovery_callback_t callback, >> void *user_data, >> bt_gatt_destroy_func_t destroy); >> + >> +void put_uuid_le(const bt_uuid_t *src, void *dst); > > gatt-helpers.h uses a namespace prefix of "bt_gatt" so you should at the > very least conform to that. The function name would then become e.g. > bt_gatt_put_uuid(). Besides that I don't have any objections to the > patch. You are absolutely right, this function does not belong here, Ive send and patch moving it to lib/uuid.h where bt_uuid is implemented since it is given as parameter here. @Gowtham, I hope you are paying attention to the outcome of these changes. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
