Hi Daniel, > Thanks for the feedback! It all makes sense, I just need clarification > on one part. > > On Thu, Feb 12, 2015 at 2:26 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: >>> + if (id->driver_info & BTUSB_RTL8723A) >>> + hdev->setup = btusb_setup_rtl8723a; >>> + >>> + if (id->driver_info & BTUSB_RTL8723B) >>> + hdev->setup = btusb_setup_rtl8723b; >>> + >> >> I would really prefer to be able to detect this with a HCI command and not have a long list of chipsets. > > Can you explain a little more what you mean here? I should have just 1 > entry point for both firmware types, where a HCI command is run, then > it dispatches the appropriate firmware loading code? > > I thought by doing it like I did in this patch, I was addressing one > of your comments on the v2 patch, where you said: > > "You do know that you can add individual hdev->setup function for each > different firmware loading mechanism. They do not need to be all the > same. I get the feeling you are trying too hard to push it all into a > single entry point." > from http://www.spinics.net/lists/linux-bluetooth/msg50141.html it might be the only way to do it. However the blacklist list is pretty long and if we have any chance to use USB_VENDOR_AND_INTERFACE_INFO to shrink that would be great. If not, then we have to deal with it. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
