Hi Luiz, > -----Original Message----- > From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth- > owner@xxxxxxxxxxxxxxx] On Behalf Of Luiz Augusto von Dentz > Sent: Friday, February 06, 2015 4:34 PM > To: linux-bluetooth@xxxxxxxxxxxxxxx > Subject: [PATCH BlueZ 12/12] client: Handle attribute notifications > > From: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > > This enable printing properties changes to the current selected attribute. > --- > client/main.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/client/main.c b/client/main.c index 57b1201..fbfd8c8 100644 > --- a/client/main.c > +++ b/client/main.c > @@ -158,6 +158,7 @@ static void print_iter(const char *label, const char > *name, > dbus_uint32_t valu32; > dbus_uint16_t valu16; > dbus_int16_t vals16; > + unsigned char byte; > const char *valstr; > DBusMessageIter subiter; > > @@ -192,6 +193,10 @@ static void print_iter(const char *label, const char > *name, > dbus_message_iter_get_basic(iter, &vals16); > rl_printf("%s%s: %d\n", label, name, vals16); > break; > + case DBUS_TYPE_BYTE: > + dbus_message_iter_get_basic(iter, &byte); > + rl_printf("%s%s: 0x%02x\n", label, name, byte); > + break; > case DBUS_TYPE_VARIANT: > dbus_message_iter_recurse(iter, &subiter); > print_iter(label, name, &subiter); > @@ -494,6 +499,14 @@ static void property_changed(GDBusProxy *proxy, > const char *name, > > print_iter(str, name, iter); > g_free(str); > + } else if (proxy == default_attr) { > + char *str; > + > + str = g_strdup_printf("[" COLORED_CHG "] Attribute %s ", > + > g_dbus_proxy_get_path(proxy)); > + > + print_iter(str, name, iter); Here I suppose, g_free(str) should come. Because the returned string (str) should be freed when no longer needed. And str = g_strdup(""); seems like Dead assignment. Other than that everything applied cleanly with no warnings/errors. Regards, Gowtham Anandha Babu > + str = g_strdup(""); > } > } > > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
