Hi Jakub,
On Sat, Feb 7, 2015 at 1:08 AM, Jakub Pawlowski <jpawlowski@xxxxxxxxxx> wrote:
> Hi,
>
> Since there are no more comments for this proposal, can we please submit
> this doc ?
> I'll send implementation for review today.
I just take a look and there some things it might be worth discussing,
see the comments bellow.
> Regards,
> Jakub
>
> On Wed, Dec 17, 2014 at 1:13 PM, Jakub Pawlowski <jpawlowski@xxxxxxxxxx> wrote:
>> This patch proposes new method, StartFilteredDiscovery to D-Bus Adapter
>> API for desktop bluetoothd. It will allow for rapid discovery of nearby
>> devices that advertise services.
>>
>> Signed-off-by: Jakub Pawlowski <jpawlowski@xxxxxxxxxx>
>> ---
>> doc/adapter-api.txt | 40 ++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 40 insertions(+)
>>
>> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
>> index 74d235a..e07c74c 100644
>> --- a/doc/adapter-api.txt
>> +++ b/doc/adapter-api.txt
>> @@ -22,6 +22,46 @@ Methods void StartDiscovery()
>> Possible errors: org.bluez.Error.NotReady
>> org.bluez.Error.Failed
>>
>> + void StartFilteredDiscovery(dict filter, string transport)
>> +
>> + This method starts the device discovery session with
>> + filtering by uuids, and rssi or pathloss value. Use
>> + StopDiscovery to release the sessions acquired.
>> +
>> + transport parameter:
>> + "auto" - interleaved scan, default value. It
>> + will cause a BR/EDR & LE interleaved
>> + scan on dual-mode controllers, on
>> + single-mode (LE-only/BREDR-only)
>> + controllers it will work on whatever
>> + the controller supports.
>> + "bredr" - br/edr inquiry
>> + "le" - le only scan
I think we can move the transport to the filters and make it optional
assuming auto by default, this would mean the signature is just a
dictionary. Btw, tere is no explanation what would happen if another
process call StartDiscovery? Id say they could coexist but the
implementation gets a bit trickier since that means we need to
overwrite the transport.
>> + Parameters that can be set in filter dictionary include
>> + the following:
>> +
>> + array{string} UUIDs : filtered service UUIDs (required)
>> + int16 RSSI : RSSI threshold value (optional)
>> + uint16 pathloss : Pathloss threshold value (optional)
>> +
>> + When a device is found that advertise any UUID from
>> + UUIDs, it will be reported if:
>> + - pathloss and RSSI are both empty,
>> + - only pathloss param is set, device advertise TX pwer,
>> + and computed pathloss is less than pathloss param,
>> + - only RSSI param is set, and received RSSI is higher
>> + than RSSI param,
>> +
>> + This process will start creating Device objects as new
>> + devices matching criteria are discovered. It will also
>> + emit PropertiesChanged signal for already existing
>> + Device objects, with updated RSSI value.
>> +
>> + Possible errors: org.bluez.Error.NotReady
>> + org.bluez.Error.Failed
>> + org.bluez.Error.InvalidArguments
>> +
>> void StopDiscovery()
>>
>> This method will cancel any previous StartDiscovery
>> --
>> 2.1.0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
