Re: [PATCH] monitor: Fix minimum size for variable length events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

> Those could lead to reading invalid memory if frames were corrupted.
> ---
> monitor/packet.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index ba58d84..56a315b 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -8204,7 +8204,7 @@ static const struct event_data event_table[] = {
> 	{ 0x01, "Inquiry Complete",
> 				inquiry_complete_evt, 1, true },
> 	{ 0x02, "Inquiry Result",
> -				inquiry_result_evt, 1, false },
> +				inquiry_result_evt, 8, false },

these are wrong. That is why fixed size is set to false here. It means that the callback function needs to ensure we do the right checks. If we don't, please with the callback functions.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux