Hi Marcel,
On Feb 2, 2015, at 10:15 AM, Kim, Ben Young Tae <ytkim@xxxxxxxxxxxxxxxx> wrote:
Hi Marcel,
On Jan 30, 2015, at 5:49 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Ben,
>
>> This patch supports ROME Bluetooth family from Qualcomm Atheros, e.g.
>> QCA61x4 or QCA6574.
>>
>> New chipset have similar firmware downloading sequences to previous
>> chipset from Atheros, however, it doesn't support vid/pid switching
>> after downloading the patch so that firmware needs to be handled by
>> btusb module directly.
>>
>> ROME chipset can be differentiated from previous version by reading
>> ROM version.
>>
>> T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 16 Spd=12 MxCh= 0
>> D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
>> P: Vendor=0cf3 ProdID=e300 Rev= 0.01
>> C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
>> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
>> E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
>> E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
>> E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
>> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
>> E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
>> E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
>> I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
>> E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
>> E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
>> I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
>> E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
>> E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
>> I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
>> E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
>> E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
>> I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
>> E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
>> E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
>> I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
>> E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
>> E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
>>
>> Signed-off-by: Ben Young Tae Kim <ytkim@xxxxxxxxxxxxxxxx>
>> ---
>> drivers/bluetooth/btusb.c | 251
>> ++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 251 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index a3a47c5..f7f39ef 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -52,6 +52,7 @@ static struct usb_driver btusb_driver;
>> #define BTUSB_SWAVE 0x1000
>> #define BTUSB_INTEL_NEW 0x2000
>> #define BTUSB_AMP 0x4000
>> +#define BTUSB_QCA_ROME 0x8000
>>
>> static const struct usb_device_id btusb_table[] = {
>> /* Generic Bluetooth USB device */
>> @@ -208,6 +209,9 @@ static const struct usb_device_id blacklist_table[] = {
>> { USB_DEVICE(0x0489, 0xe036), .driver_info = BTUSB_ATH3012 },
>> { USB_DEVICE(0x0489, 0xe03c), .driver_info = BTUSB_ATH3012 },
>>
>> + /* QCA ROME chipset */
>> + { USB_DEVICE(0x0cf3, 0xe300), .driver_info = BTUSB_QCA_ROME},
>> +
>> /* Broadcom BCM2035 */
>> { USB_DEVICE(0x0a5c, 0x2009), .driver_info = BTUSB_BCM92035 },
>> { USB_DEVICE(0x0a5c, 0x200a), .driver_info = BTUSB_WRONG_SCO_MTU },
>> @@ -2580,6 +2584,248 @@ static int btusb_set_bdaddr_ath3012(struct hci_dev *hdev,
>> return 0;
>> }
>>
>> +#define QCA_DFU_PACKET_LEN 4096
>> +
>> +#define QCA_GET_TARGET_VERSION 0x09
>> +#define QCA_CHECK_STATUS 0x05
>> +#define QCA_DFU_DOWNLOAD 0x01
>> +
>> +#define QCA_SYSCFG_UPDATED 0x40
>> +#define QCA_PATCH_UPDATED 0x80
>> +#define QCA_DFU_TIMEOUT 3000
>> +
>> +struct qca_version {
>> + __le32 rom_version;
>> + __le32 patch_version;
>> + __le32 ram_version;
>> + __le32 ref_clock;
>> + __u8 reserved[4];
>> +} __packed;
>> +
>> +struct qca_rampatch_version {
>> + __le16 rom_version;
>> + __le16 patch_version;
>> +} __packed;
>> +
>> +struct qca_device_info {
>> + __le32 rom_version;
>> + __u8 rampatch_hdr; /* length of header in rampatch */
>> + __u8 nvm_hdr; /* length of header in NVM */
>> + __u8 ver_offset; /* offset of version structure in rampatch */
>> +};
>> +
>> +static const struct qca_device_info qca_devices_table[] = {
>> + { 0x00000100, 20, 4, 10 }, /* Rome 1.0 */
>> + { 0x00000101, 20, 4, 10 }, /* Rome 1.1 */
>> + { 0x00000201, 28, 4, 18 }, /* Rome 2.1 */
>> + { 0x00000300, 28, 4, 18 }, /* Rome 3.0 */
>> + { 0x00000302, 28, 4, 18 }, /* Rome 3.2 */ };
>> +
>> +static int btusb_qca_send_vendor_req(struct hci_dev *hdev, u8 request,
>> + void *data, u16 size)
>> +{
>> + struct btusb_data *btdata = hci_get_drvdata(hdev);
>> + struct usb_device *udev = btdata->udev;
>> + int pipe, err;
>> + u8 *buf;
>> +
>> + buf = kmalloc(size, GFP_KERNEL);
>> + if (!buf)
>> + return -ENOMEM;
>> +
>> + /* To access OTP(one time programing) memory area at early stage,
>> + * use USB endpoint instead of VS HCI command because HCI path may
>> + * not be ready to access OTP area.
>> + */
>> + pipe = usb_rcvctrlpipe(udev, 0);
>> + err = usb_control_msg(udev, pipe, request, USB_TYPE_VENDOR | USB_DIR_IN,
>> + 0, 0, buf, size, USB_CTRL_SET_TIMEOUT);
>> + if (err < 0) {
>> + BT_ERR("%s: Failed to access otp area (%d)", hdev->name, err);
>> + goto done;
>> + }
>> +
>> + memcpy(data, buf, size);
>> +
>> +done:
>> + kfree(buf);
>> +
>> + return err;
>> +}
>> +
>> +static int btusb_setup_qca_download_fw(struct hci_dev *hdev,
>> + const struct firmware *firmware,
>> + size_t hdr_size)
>> +{
>> + struct btusb_data *btdata = hci_get_drvdata(hdev);
>> + struct usb_device *udev = btdata->udev;
>> + size_t count, size, sent = 0;
>> + int pipe, len, err;
>> + u8 *buf;
>> +
>> + buf = kmalloc(QCA_DFU_PACKET_LEN, GFP_KERNEL);
>> + if (!buf)
>> + return -ENOMEM;
>> +
>> + count = firmware->size;
>> +
>> + size = min_t(size_t, count, hdr_size);
>> + memcpy(buf, firmware->data, size);
>> +
>> + /* Patch header goes down through control path */
>> + pipe = usb_sndctrlpipe(udev, 0);
>> + err = usb_control_msg(udev, pipe, QCA_DFU_DOWNLOAD, USB_TYPE_VENDOR,
>> + 0, 0, buf, size, USB_CTRL_SET_TIMEOUT);
>> + if (err < 0) {
>> + BT_ERR("%s: Failed to send headers (%d)", hdev->name, err);
>> + goto done;
>> + }
>> +
>> + sent += size;
>> + count -= size;
>> +
>> + while (count) {
>> + size = min_t(size_t, count, QCA_DFU_PACKET_LEN);
>> +
>> + memcpy(buf, firmware->data + sent, size);
>> +
>> + /* Patch body goes down through bulk channel */
>> + pipe = usb_sndbulkpipe(udev, 0x02);
>> + err = usb_bulk_msg(udev, pipe, buf, size, &len,
>> + QCA_DFU_TIMEOUT);
>> + if (err < 0) {
>> + BT_ERR("%s: Failed to send body at %zd of %zd (%d)",
>> + hdev->name, sent, firmware->size, err);
>> + break;
>> + }
>> +
>> + if (size != len) {
>> + BT_ERR("%s: Failed to get bulk buffer", hdev->name);
>> + err = -EILSEQ;
>> + break;
>> + }
>> +
>> + sent += size;
>> + count -= size;
>> + }
>> +
>> +done:
>> + kfree(buf);
>> + return err;
>> +}
>> +
>> +static int btusb_setup_qca_load_rampatch(struct hci_dev *hdev,
>> + struct qca_version *ver,
>> + const struct qca_device_info *info) {
>> + struct qca_rampatch_version *rver;
>> + const struct firmware *fw;
>> + char fwname[64];
>> + int err;
>> +
>> + snprintf(fwname, sizeof(fwname), "qca/rampatch_usb_%08x.bin",
>> + le32_to_cpu(ver->rom_version));
>> +
>> + err = request_firmware(&fw, fwname, &hdev->dev);
>> + if (err) {
>> + BT_ERR("%s: failed to request rampatch file: %s (%d)",
>> + hdev->name, fwname, err);
>> + return err;
>> + }
>> +
>> + BT_INFO("%s: using rampatch file: %s", hdev->name, fwname);
>> + rver = (struct qca_rampatch_version *)(fw->data + info->ver_offset);
>> + BT_INFO("%s: QCA: patch rome 0x%x build 0x%x, firmware rome 0x%x "
>> + "build 0x%x", hdev->name, le16_to_cpu(rver->rom_version),
>> + le16_to_cpu(rver->patch_version), le32_to_cpu(ver->rom_version),
>> + le32_to_cpu(ver->patch_version));
>> +
>> + if (rver->rom_version != ver->rom_version ||
>> + rver->patch_version <= ver->patch_version) {
>> + BT_ERR("%s: rampatch file version did not match with firmware",
>> + hdev->name);
>> + err = -EINVAL;
>> + goto done;
>> + }
>> +
>> + err = btusb_setup_qca_download_fw(hdev, fw, info->rampatch_hdr);
>> +
>> +done:
>> + release_firmware(fw);
>> +
>> + return err;
>> +}
>> +
>> +static int btusb_setup_qca_load_nvm(struct hci_dev *hdev,
>> + struct qca_version *ver,
>> + const struct qca_device_info *info) {
>> + const struct firmware *fw;
>> + char fwname[64];
>> + int err;
>> +
>> + snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x.bin",
>> + le32_to_cpu(ver->rom_version));
>> +
>> + err = request_firmware(&fw, fwname, &hdev->dev);
>> + if (err) {
>> + BT_ERR("%s: failed to request NVM file: %s (%d)",
>> + hdev->name, fwname, err);
>> + return err;
>> + }
>> +
>> + BT_INFO("%s: using NVM file: %s", hdev->name, fwname);
>> +
>> + err = btusb_setup_qca_download_fw(hdev, fw, info->nvm_hdr);
>> +
>> + release_firmware(fw);
>> +
>> + return err;
>> +}
>> +
>> +static int btusb_setup_qca(struct hci_dev *hdev) {
>> + const struct qca_device_info *info = NULL;
>> + struct qca_version ver;
>> + u8 status;
>> + int i, err;
>> +
>> + err = btusb_qca_send_vendor_req(hdev, QCA_GET_TARGET_VERSION, &ver,
>> + sizeof(ver));
>> + if (err < 0)
>> + return err;
>> +
>> + for (i = 0; i < ARRAY_SIZE(qca_devices_table); i++) {
>> + if (ver.rom_version == qca_devices_table[i].rom_version)
>> + info = &qca_devices_table[i];
>> + }
>> + if (!info) {
>> + BT_ERR("%s: don't support firmware rome 0x%x", hdev->name,
>> + le32_to_cpu(ver.rom_version));
>> + return -ENODEV;
>> + }
>> +
>> + err = btusb_qca_send_vendor_req(hdev, QCA_CHECK_STATUS, &status,
>> + sizeof(status));
>> + if (err < 0)
>> + return err;
>> +
>> + if (!(status & QCA_PATCH_UPDATED)) {
>> + err = btusb_setup_qca_load_rampatch(hdev, &ver, info);
>> + if (err < 0)
>> + return err;
>> + }
>> +
>> + if (!(status & QCA_SYSCFG_UPDATED)) {
>> + err = btusb_setup_qca_load_nvm(hdev, &ver, info);
>> + if (err < 0)
>> + return err;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> static int btusb_probe(struct usb_interface *intf,
>> const struct usb_device_id *id) { @@ -2730,6 +2976,11 @@
>> static int btusb_probe(struct usb_interface *intf,
>> set_bit(HCI_QUIRK_STRICT_DUPLICATE_FILTER, &hdev->quirks);
>> }
>>
>> + if (id->driver_info & BTUSB_QCA_ROME) {
>> + hdev->setup = btusb_setup_qca;
>> + hdev->set_bdaddr = btusb_set_bdaddr_ath3012;
>> + }
>> +
>
> patch looks fine, but I just realized that using hdev->setup is actually misusing that callback. We introduced that callback for drivers that have to send HCI commands before the generic stack can take over. This means actually that the HCI transport is set up and fully operational.
>
> If you hardware is not even providing a functional HCI transport after USB enumeration, then it should not actually declare Bluetooth Class descriptors in the first place. However it seems you do:
>
> T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 16 Spd=12 MxCh= 0
> D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=0cf3 ProdID=e300 Rev= 0.01
>
> So why again, can we not use HCI commands to actually load the patches and NVM entries? I seem to be failing to still get this. And why are we doing this when the HCI transport is already running. When hdev->setup is executed, we have Interrupt and Bulk URBs in flight to handle data reception. That seems not like a smart thing to do. So the HCI transport has Bulk URBs for IN endpoint pending and you start sending Bulk traffic to the OUT endpoint. This seems pretty dangerous to me.
>
> The control endpoint has to some degree a built in multiplexing capability and I can see that this is acceptable, but the bulk endpoints don't have that. It is pure data. And it is suppose to be ACL data.
>
> Do you have a bit more background on how your chips work since I am not convinced we are executing this patching and NVM loading at the right time. All the other manufacturers are using HCI in one shape or another, but it is still HCI. This is something different and I am afraid that hdev->setup is not the right trigger for this.
>
While USB patching method is coming from HW team, I had checked with them. They said main reason is we have experienced some of USB host has some IOT issues with ours so that we shouldn't wait until HCI layer is ready. Most of trial was okay for using HCI VS path but it was not 100% successful at the early stage. Another reason we have to use USB patching VS command is that we have changed USB patch file format comparing with UART patch file. The USB patch file is exactly fitting to go down through USB path because our HCI VS requires to add header binaries for every packets but USB patch file does not have every header binaries inside. Our UART patch is going to down HCI VS path and USB patch file should be downloading to USB VS path for ROME chipset.
> Regards
>
> Marcel
I think there is no other option to setup patching & NVM files except using USB channel on ROME. If you have some concern to use hdev->setup, is it okay to move to probe function? Please let me know your recommendation to moving forward.
Thanks
- Ben Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
