Re: [PATCH v2] Bluetooth: Fix sending Read Remote Extended Features command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Szymon,

> This command should only be used if remote device reports that it
> supports extended features. Otherwise command will fail and connection
> will be dropped.
> 
> Some devices support SSP but don't support extended features so
> current check for SSP support is not enought.
> 
> Instead of checking for SSP support just check if both ends support
> Extended Feature.
> 
> < HCI Command: Create Connection (0x01|0x0005) plen 13
>        Address: D0:9C:30:00:19:6F (Foster Electric Company, Limited)
>        Packet type: 0xcc18
>          DM1 may be used
>          DH1 may be used
>          DM3 may be used
>          DH3 may be used
>          DM5 may be used
>          DH5 may be used
>        Page scan repetition mode: R1 (0x01)
>        Page scan mode: Mandatory (0x00)
>        Clock offset: 0x94c8
>        Role switch: Allow slave (0x01)
>> HCI Event: Command Status (0x0f) plen 4
>      Create Connection (0x01|0x0005) ncmd 1
>        Status: Success (0x00)
>> HCI Event: Connect Complete (0x03) plen 11
>        Status: Success (0x00)
>        Handle: 5
>        Address: D0:9C:30:00:19:6F (Foster Electric Company, Limited)
>        Link type: ACL (0x01)
>        Encryption: Disabled (0x00)
> < HCI Command: Read Remote Supported Features (0x01|0x001b) plen 2
>        Handle: 5
>> HCI Event: Command Status (0x0f) plen 4
>      Read Remote Supported Features (0x01|0x001b) ncmd 1
>        Status: Success (0x00)
>> HCI Event: Page Scan Repetition Mode Change (0x20) plen 7
>        Address: D0:9C:30:00:19:6F (Foster Electric Company, Limited)
>        Page scan repetition mode: R1 (0x01)
>> HCI Event: Read Remote Supported Features (0x0b) plen 11
>        Status: Success (0x00)
>        Handle: 5
>        Features: 0xff 0xff 0x8f 0xfe 0xdb 0xff 0x5b 0x07
>          3 slot packets
>          5 slot packets
>          Encryption
>          Slot offset
>          Timing accuracy
>          Role switch
>          Hold mode
>          Sniff mode
>          Park state
>          Power control requests
>          Channel quality driven data rate (CQDDR)
>          SCO link
>          HV2 packets
>          HV3 packets
>          u-law log synchronous data
>          A-law log synchronous data
>          CVSD synchronous data
>          Paging parameter negotiation
>          Power control
>          Transparent synchronous data
>          Broadcast Encryption
>          Enhanced Data Rate ACL 2 Mbps mode
>          Enhanced Data Rate ACL 3 Mbps mode
>          Enhanced inquiry scan
>          Interlaced inquiry scan
>          Interlaced page scan
>          RSSI with inquiry results
>          Extended SCO link (EV3 packets)
>          EV4 packets
>          EV5 packets
>          AFH capable slave
>          AFH classification slave
>          LE Supported (Controller)
>          3-slot Enhanced Data Rate ACL packets
>          5-slot Enhanced Data Rate ACL packets
>          Sniff subrating
>          Pause encryption
>          AFH capable master
>          AFH classification master
>          Enhanced Data Rate eSCO 2 Mbps mode
>          Enhanced Data Rate eSCO 3 Mbps mode
>          3-slot Enhanced Data Rate eSCO packets
>          Extended Inquiry Response
>          Simultaneous LE and BR/EDR (Controller)
>          Secure Simple Pairing
>          Encapsulated PDU
>          Non-flushable Packet Boundary Flag
>          Link Supervision Timeout Changed Event
>          Inquiry TX Power Level
>          Enhanced Power Control
> < HCI Command: Read Remote Extended Features (0x01|0x001c) plen 3
>        Handle: 5
>        Page: 1
>> HCI Event: Command Status (0x0f) plen 4
>      Read Remote Extended Features (0x01|0x001c) ncmd 1
>        Status: Command Disallowed (0x0c)
> < HCI Command: Read Clock Offset (0x01|0x001f) plen 2
>        Handle: 5
>> HCI Event: Command Status (0x0f) plen 4
>      Read Clock Offset (0x01|0x001f) ncmd 1
>        Status: Success (0x00)
> < HCI Command: Disconnect (0x01|0x0006) plen 3
>        Handle: 5
>        Reason: Remote User Terminated Connection (0x13)
> 
> Signed-off-by: Szymon Janc <szymon.janc@xxxxxxxxx>
> ---
> 
> V2 - check for lmp_ext_feat_capable on both ends instead of
>     ssp check as suggested by Marcel
> 
> net/bluetooth/hci_event.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux