Ping. > -----Original Message----- > From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth- > owner@xxxxxxxxxxxxxxx] On Behalf Of Gowtham Anandha Babu > Sent: Wednesday, January 14, 2015 3:28 PM > To: linux-bluetooth@xxxxxxxxxxxxxxx > Cc: bharat.panda@xxxxxxxxxxx; cpgs@xxxxxxxxxxx; Gowtham Anandha > Babu > Subject: [PATCH 1/3] shared/gatt-helpers: Fix usage of freed memory > > src/shared/gatt-client.c:472:14: warning: Use of memory after it is freed > op->success = false; > ~~~~~~~~~~~ ^ > src/shared/gatt-client.c:627:14: warning: Use of memory after it is freed > op->success = success; > ~~~~~~~~~~~ ^ > src/shared/gatt-client.c:728:14: warning: Use of memory after it is freed > op->success = success; > ~~~~~~~~~~~ ^ > src/shared/gatt-client.c:820:14: warning: Use of memory after it is freed > op->success = success; > ~~~~~~~~~~~ ^ > src/shared/gatt-client.c:888:14: warning: Use of memory after it is freed > op->success = success; > ~~~~~~~~~~~ ^ > src/shared/gatt-client.c:1909:2: warning: Use of memory after it is freed > complete_read_long_op(op, success, att_ecode); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > src/shared/gatt-client.c:2126:2: warning: Use of memory after it is freed > complete_write_long_op(op, success, 0, false); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > src/shared/gatt-client.c:2194:6: warning: Use of memory after it is freed > if (op->callback) > ^~~~~~~~~~~~ > --- > src/shared/gatt-helpers.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) > > diff --git a/src/shared/gatt-helpers.c b/src/shared/gatt-helpers.c index > c6e179c..a25f1ad 100644 > --- a/src/shared/gatt-helpers.c > +++ b/src/shared/gatt-helpers.c > @@ -686,7 +686,6 @@ static void read_by_grp_type_cb(uint8_t opcode, > const void *pdu, > discovery_op_unref)) > return; > > - discovery_op_unref(op); > success = false; > goto done; > } > @@ -708,6 +707,8 @@ success: > done: > if (op->callback) > op->callback(success, att_ecode, final_result, op- > >user_data); > + > + discovery_op_unref(op); > } > > static void find_by_type_val_cb(uint8_t opcode, const void *pdu, @@ - > 766,7 +767,6 @@ static void find_by_type_val_cb(uint8_t opcode, const void > *pdu, > discovery_op_unref)) > return; > > - discovery_op_unref(op); > success = false; > goto done; > } > @@ -779,6 +779,8 @@ success: > done: > if (op->callback) > op->callback(success, att_ecode, final_result, op- > >user_data); > + > + discovery_op_unref(op); > } > > static bool discover_services(struct bt_att *att, bt_uuid_t *uuid, @@ -977,7 > +979,6 @@ static void read_included_cb(uint8_t opcode, const void *pdu, > discovery_op_ref(op), discovery_op_unref)) > return; > > - discovery_op_unref(op); > success = false; > goto done; > } > @@ -997,6 +998,8 @@ static void read_included_cb(uint8_t opcode, const > void *pdu, > done: > if (op->callback) > op->callback(success, att_ecode, final_result, op- > >user_data); > + > + discovery_op_unref(op); > } > > static void read_included(struct read_incl_data *data) @@ -1014,10 > +1017,10 @@ static void read_included(struct read_incl_data *data) > > read_included_unref)) > return; > > - read_included_unref(data); > - > if (op->callback) > op->callback(false, 0, NULL, data->op->user_data); > + > + read_included_unref(data); > } > > static void discover_included_cb(uint8_t opcode, const void *pdu, @@ - > 1099,7 +1102,6 @@ static void discover_included_cb(uint8_t opcode, const > void *pdu, > discovery_op_unref)) > return; > > - discovery_op_unref(op); > success = false; > goto failed; > } > @@ -1111,6 +1113,8 @@ done: > failed: > if (op->callback) > op->callback(success, att_ecode, final_result, op- > >user_data); > + > + discovery_op_unref(op); > } > > bool bt_gatt_discover_included_services(struct bt_att *att, @@ -1213,7 > +1217,6 @@ static void discover_chrcs_cb(uint8_t opcode, const void *pdu, > discovery_op_unref)) > return; > > - discovery_op_unref(op); > success = false; > goto done; > } > @@ -1226,6 +1229,8 @@ done: > if (op->callback) > op->callback(success, att_ecode, final_result, > op->user_data); > + > + discovery_op_unref(op); > } > > bool bt_gatt_discover_characteristics(struct bt_att *att, @@ -1321,7 +1326,6 > @@ static void read_by_type_cb(uint8_t opcode, const void *pdu, > discovery_op_unref)) > return; > > - discovery_op_unref(op); > success = false; > goto done; > } > @@ -1332,6 +1336,8 @@ done: > if (op->callback) > op->callback(success, att_ecode, success ? op->result_head : > NULL, op- > >user_data); > + > + discovery_op_unref(op); > } > > bool bt_gatt_read_by_type(struct bt_att *att, uint16_t start, uint16_t end, > @@ -1439,7 +1445,6 @@ static void discover_descs_cb(uint8_t opcode, > const void *pdu, > discovery_op_unref)) > return; > > - discovery_op_unref(op); > success = false; > goto done; > } > @@ -1451,6 +1456,8 @@ success: > done: > if (op->callback) > op->callback(success, att_ecode, final_result, op- > >user_data); > + > + discovery_op_unref(op); > } > > bool bt_gatt_discover_descriptors(struct bt_att *att, > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
