Re: [PATCH] src/att: Fix usage of memory after it is freed.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Jan 7, 2015 at 7:56 AM, Gowtham Anandha Babu
<gowtham.ab@xxxxxxxxxxx> wrote:
> Ping.
>
>> -----Original Message-----
>> From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-
>> owner@xxxxxxxxxxxxxxx] On Behalf Of Gowtham Anandha Babu
>> Sent: Friday, December 19, 2014 7:31 PM
>> To: linux-bluetooth@xxxxxxxxxxxxxxx
>> Cc: d.kasatkin@xxxxxxxxxxx; bharat.panda@xxxxxxxxxxx;
>> cpgs@xxxxxxxxxxx; Gowtham Anandha Babu
>> Subject: [PATCH] src/att: Fix usage of memory after it is freed.
>>
>> warning: Use of memory after it is freed
>>       respond_not_supported(att, opcode);
>>       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ---
>>  src/shared/att.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/shared/att.c b/src/shared/att.c index 4be0652..a98909e
>> 100644
>> --- a/src/shared/att.c
>> +++ b/src/shared/att.c
>> @@ -692,14 +692,14 @@ static void handle_notify(struct bt_att *att,
> uint8_t
>> opcode, uint8_t *pdu,
>>
>>       queue_foreach(att->notify_list, notify_handler, &data);
>>
>> -     bt_att_unref(att);
>> -
>>       /*
>>        * If this was a request and no handler was registered for it,
> respond
>>        * with "Not Supported"
>>        */
>>       if (!data.handler_found && get_op_type(opcode) ==
>> ATT_OP_TYPE_REQ)
>>               respond_not_supported(att, opcode);
>> +
>> +     bt_att_unref(att);
>>  }
>>
>>  static bool can_read_data(struct io *io, void *user_data)
>> --
>> 1.9.1

Applied, thanks.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux