This patch adds handling for Service Changed events. All exported objects that match attributes within the changed handle range are unregistered and new ones get exported based on the newly discovered services. --- src/device.c | 4 ++-- src/gatt-client.c | 35 +++++++++++++++++++++++++++++++---- 2 files changed, 33 insertions(+), 6 deletions(-) diff --git a/src/device.c b/src/device.c index 0abed9b..346b68d 100644 --- a/src/device.c +++ b/src/device.c @@ -2703,7 +2703,7 @@ static void gatt_service_added(struct gatt_db_attribute *attr, void *user_data) if (l) service_accept(l->data); - store_services(device); + store_device_info(device); btd_gatt_client_service_added(device->client_dbus, attr); } @@ -2775,7 +2775,7 @@ static void gatt_service_removed(struct gatt_db_attribute *attr, g_free(prim); - store_services(device); + store_device_info(device); btd_gatt_client_service_removed(device->client_dbus, attr); } diff --git a/src/gatt-client.c b/src/gatt-client.c index c4f3582..cbafdef 100644 --- a/src/gatt-client.c +++ b/src/gatt-client.c @@ -1521,6 +1521,11 @@ static void unregister_service(void *data) static void notify_chrcs(struct service *service) { + + if (service->chrcs_ready || + !queue_isempty(service->pending_ext_props)) + return; + service->chrcs_ready = true; g_dbus_emit_property_changed(btd_get_dbus_connection(), service->path, @@ -1577,8 +1582,7 @@ static void read_ext_props_cb(bool success, uint8_t att_ecode, queue_remove(service->pending_ext_props, chrc); - if (queue_isempty(service->pending_ext_props)) - notify_chrcs(service); + notify_chrcs(service); } static void read_ext_props(void *data, void *user_data) @@ -1760,13 +1764,36 @@ void btd_gatt_client_ready(struct btd_gatt_client *client) void btd_gatt_client_service_added(struct btd_gatt_client *client, struct gatt_db_attribute *attrib) { - /* TODO */ + if (!client) + return; + + export_service(attrib, client); +} + +static bool match_service_handle(const void *a, const void *b) +{ + const struct service *service = a; + uint16_t start_handle = PTR_TO_UINT(b); + + return service->start_handle == start_handle; } void btd_gatt_client_service_removed(struct btd_gatt_client *client, struct gatt_db_attribute *attrib) { - /* TODO */ + uint16_t start_handle, end_handle; + + if (!client || !attrib) + return; + + gatt_db_attribute_get_service_handles(attrib, &start_handle, + &end_handle); + + DBG("GATT Services Removed - start: 0x%04x, end: 0x%04x", start_handle, + end_handle); + queue_remove_all(client->services, match_service_handle, + UINT_TO_PTR(start_handle), + unregister_service); } void btd_gatt_client_disconnected(struct btd_gatt_client *client) -- 2.2.0.rc0.207.ga3a616c -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html