Re: [PATCH 1/4] Bluetooth: btmrvl: fix race issue while stopping main thread

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Amitkumar,

>>> btmrvl_remove_card() calls kthread_stop() to stop the main thread, but
>>> kthread_should_stop() is checked when all the activities are done in
>>> the main thread before sleeping.
>>> We will have kthread_should_stop() check as soon as main thread is
>>> woken up. This fixes a crash issue caused due to an invalid memory
>>> access while unnecessarily processing interrupts after card removal.
>>> 
>>> Signed-off-by: Avinash Patil <patila@xxxxxxxxxxx>
>>> Signed-off-by: Cathy Luo <cluo@xxxxxxxxxxx>
>>> Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
>> 
>> I can not apply the patches like this. I assume that Avinash wrote the
>> patch and with that he should be listed as patch author. So the email
>> needs a proper From: line that allows git am to pick this up properly.
>> 
>> Same applies to the other 3 patches.
>> 
> 
> Do you mean the patch author's Signed-off should be always first? In that case I'll change signed off sequence accordingly and send updated version.
> All 4 patches are written by me.

the first Signed-off-by is the patch author. This means all the other should be Reviewed-by lines.

The chain of Signed-off-by lines shows on who took a patch and submitting along the chain towards upstream. That means the author is the first one. Then I would be the second and so on.

If someone else wrote the patch, then he/she is first, if you then take it and submit it to linux-bluetooth that means you add a Signed-off-by since you send it. However the author stays the same and the first Signed-off-by is still the authors.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux