Hi Andrei, On Friday 19 of December 2014 11:24:40 Andrei Emeltchenko wrote: > From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx> > > gatt_db_attribute_get_permissions() used everywhere without check since > those conditions are checked already. > --- > android/gatt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/android/gatt.c b/android/gatt.c > index 0258d91..169f6db 100644 > --- a/android/gatt.c > +++ b/android/gatt.c > @@ -6311,8 +6311,7 @@ static void write_cmd_request(const uint8_t *cmd, uint16_t cmd_len, > if (!attrib) > return; > > - if (!gatt_db_attribute_get_permissions(attrib, &permissions)) > - return; > + gatt_db_attribute_get_permissions(attrib, &permissions); > > if (check_device_permissions(dev, cmd[0], permissions)) > return; Wasn't identical patch already reviewed few weeks ago? -- Best regards, Szymon Janc -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html