Re: [PATCH] Bluetooth: 6lowpan: Do not free skb when packet is dropped

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jukka,

>> If we need to drop the message because of some error in the
>> compression etc, then do not free the skb as that is done
>> automatically in other part of networking stack.
>> 
>> Signed-off-by: Jukka Rissanen <jukka.rissanen@xxxxxxxxxxxxxxx>
>> ---
>> net/bluetooth/6lowpan.c | 1 -
>> 1 file changed, 1 deletion(-)
>> 
>> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
>> index bdcaefd..ca5b4ec 100644
>> --- a/net/bluetooth/6lowpan.c
>> +++ b/net/bluetooth/6lowpan.c
>> @@ -390,7 +390,6 @@ static int recv_pkt(struct sk_buff *skb, struct net_device *dev,
>> 
>> drop:
>> 	dev->stats.rx_dropped++;
>> -	kfree_skb(skb);
>> 	return NET_RX_DROP;
>> }
>> 
> 
> 
> This patch should be applied at least in bluetooth-next. I have not seen
> any errors in earlier kernels as we never seem to go to this branch but
> because of Alex's ip header compression patches (that are still
> pending), this error branch will be hit quite easily in the future. The
> patch could be applied also to earlier kernels just in case.

are we talking about 3.19 candidate or 3.20 kernel?

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux