Hi Marcel,
On Mon, Dec 15, 2014 at 12:53 PM, Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
> Hi Luiz,
>
>
>>> With this patch it is possible to send ATT request with a given id
>>> request. It might be useful for ATT user for example to keep track of
>>> the GATT request which requires more then one ATT request e.g. search
>>> services
>>> ---
>>> src/shared/att.c | 26 ++++++++++++++++++++++++++
>>> src/shared/att.h | 6 ++++++
>>> 2 files changed, 32 insertions(+)
>>>
>>> diff --git a/src/shared/att.c b/src/shared/att.c
>>> index 2a131e0..f51f893 100644
>>> --- a/src/shared/att.c
>>> +++ b/src/shared/att.c
>>> @@ -1083,6 +1083,32 @@ static unsigned int send_att(struct bt_att *att, struct att_send_op *op)
>>> return op->id;
>>> }
>>>
>>> +unsigned int bt_att_send_with_id(struct bt_att *att, unsigned int id,
>>> + uint8_t opcode, const void *pdu,
>>> + uint16_t length,
>>> + bt_att_response_func_t callback,
>>> + void *user_data,
>>> + bt_att_destroy_func_t destroy)
>>> +{
>>> + struct att_send_op *op;
>>> +
>>> + if (!att || !att->io)
>>> + return 0;
>>
>> I guess we need to check for invalid id here, or we can do the
>> opposite and let 0 id be used for self assign an id so bt_att_send
>> could just bt_att_send_with_id so we reuse more code.
>>
>>> + op = create_att_send_op(opcode, pdu, length, att->mtu, callback,
>>> + user_data, destroy);
>>> + if (!op)
>>> + return 0;
>>>
>>> + /*
>>> + * TODO: Some verification might be needed here. For now we
>>> + * believe that user know what he is doing.
>>> + */
>>> + op->id = id;
>>
>> I think we should prevent multiple entries using the same id and Im
>> also not sure why this is not being queue like the rest of operations?
>
> or we are not doing this at all since this sounds like a crazy API.
>
> If the caller wants to keep track of something, then it can keep track of it, but we are not allowing the caller to mess with internals.
Well this is done internally so the caller can cancel operations such
as discovery, we could add another id but the caller would have no
idea the id has changed perhaps we could add an id mapping between
gatt and att so the id on gatt won't change but the att id would, but
with that we would need to change gattrib to do the same.
--
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
