On Fri, Dec 12, 2014 at 02:58:30PM +0100, Marcel Holtmann wrote:
Hi Marcel,
> >
> > +config BT_HCIUART_BCSP_WINSIZE
> > + int "BCSP reliable packet TX window size"
> > + default 4
> > + depends on BT_HCIUART_BCSP
> > + help
> > + Defines the number of packets that can be sent before receiving a ACK.
> > +
>
> I would prefer if we get a bit more help text here.
>
Yes, I can make it a bit more explicit and descriptive.
> >
> > - if (bcsp->unack.qlen < BCSP_TXWINSIZE) {
> > + if (bcsp->unack.qlen < CONFIG_BT_HCIUART_BCSP_WINSIZE) {
> > skb = skb_dequeue(&bcsp->rel);
> > if (skb != NULL) {
> > struct sk_buff *nskb = bcsp_prepare_pkt(bcsp, skb->data, skb->len,
>
> This is fine with me, but we might also want to add a module parameter to allow changing it. If people want to play with it then they do not need to rebuild their module.
>
> Another alternative is to provide an ioctl for changing it.
That makes sense, I think a parameter is a good solution, and if nobody shows any preference, I'll implement it this way.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
