Re: Re: [PATCH 2/2] Bluetooth: Fix missing hci_dev_lock/unlock in hci_event

[JAGANATH KANAKKASSERY <jaganath.k@xxxxxxxxxxx>]

Hi Marcel,

>> static void hci_cc_read_local_version(struct hci_dev *hdev, struct sk_buff *skb)
>> @@ -1172,11 +1184,14 @@ static void hci_cc_le_set_scan_enable(struct hci_dev *hdev,
>> 		 * re-enable it again if necessary.
>> 		 */
>> 		if (test_and_clear_bit(HCI_LE_SCAN_INTERRUPTED,
>>-				       &hdev->dev_flags))
>> +				       &hdev->dev_flags)) {
>> +			hci_dev_lock(hdev);
>> 			hci_discovery_set_state(hdev, DISCOVERY_STOPPED);
>> -		else if (!test_bit(HCI_LE_ADV, &hdev->dev_flags) &&
>> -			 hdev->discovery.state == DISCOVERY_FINDING)
>> +			hci_dev_unlock(hdev);
>> +		} else if (!test_bit(HCI_LE_ADV, &hdev->dev_flags) &&
>> +			 hdev->discovery.state == DISCOVERY_FINDING) {
>
>the indentation is still violating the coding style here. It needs to align with !test_bit. Same as before.

I have raised a new patch after fixing it. Plz check.

Thanks,
Jaganathÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±ý¹nzÚ(¶âžØ^n‡r¡ö¦zË?ëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿï?êÿ‘êçz_è®æj:+v‰¨þ)ߣøm