Hi Jukka, On Wed, Dec 10, 2014 at 01:56:14PM +0200, Jukka Rissanen wrote: > > Found the problem, in bt 6lowpan the skb that was freed was still used > by network stack. I will send a patch for this soon. > ok. > > > > > > > > > > > > > > > Do this please on one node, the other node should send some 6LoWPAN IPHC > > > > > packets to check if the error handling working there. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Another issue is that I see that skb->dev isn't set before calling > > > > > lowpan_header_decompress. Because inside your log is a "NULL": > > > > > > > > > > (NULL net_device): received unknown nhc id which was not found. > > > > > > > > > > Can you change that? That skb->dev is set to before calling > > > > > lowpan_header_decompress. > > > > > > > > I am setting the skb->dev after the call to lowpan_header_decompress(). > > > > And anyway the skb->dev is only used when printing the err. > > > > Actually should we replace the skb->dev in lowpan_header_decompress() > > > > with plain dev as that is given to the function as a parameter. > > > > > > > > > > Ok, how we introduce this now? You wanna add this do the patch series for > > > fixing the above issue, or should I add it to my patch series for > > > introduce nhc framework? > > > > I am fine with either. If you have time, please go ahead and send a > > patch or I can do it also after figuring what is causing the crash. > > After second though, can you do the change as actually what I had in > mind was to change the > > netdev_warn(skb->dev, ...) > to > netdev_warn(dev, ...) > > and that code is part of patch 2 of your patchset. > > Another thing I noticed is that we need to rate limit the output as now > it might be that the warning is printed for every udp packet which is > way too much. > ok. Or maybe simple remove the output, or make it only visable on debugging. I don't really know what's the best notice for use that the packet was dropping because invalid/unsupported packets. I will do it to ratelimit and add patches for the netdev_warn(dev, ...) thing. Currently I am working a little bit on the 802154 branch again. I will start this work when you are done with the above fix. - Alex -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
