Hi Szymon, > -----Original Message----- > From: Szymon Janc [mailto:szymon.janc@xxxxxxxxx] > Sent: Tuesday, December 09, 2014 6:54 PM > To: Gowtham Anandha Babu > Cc: linux-bluetooth@xxxxxxxxxxxxxxx; d.kasatkin@xxxxxxxxxxx; > bharat.panda@xxxxxxxxxxx; cpgs@xxxxxxxxxxx > Subject: Re: [PATCH ] android/socket: Add PBAP supported features bits > > Hi Gowtham, > > On Tuesday 09 of December 2014 18:21:27 Gowtham Anandha Babu wrote: > > Add PBAP supported features in sdp record. > > Isn't that a 1.2 feature? (AOSP supports only 1.1). Yes, this one is 1.2 feature. Then, I have to wait till 1.2 release. Btw, Right now in android, Server (PBAP-PSE and MAP-MAS) records are getting added. What happened to client(PBAP-PCE and MAP-MNS) records? Will it be added only after implementing them? Am I right? > > Same goes with MAP. > > > --- > > android/socket.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/android/socket.c b/android/socket.c index > > 2b836e9..f2cfd07 100644 > > --- a/android/socket.c > > +++ b/android/socket.c > > @@ -58,6 +58,8 @@ > > /* Hardcoded MAP stuff needed for MAS SMS Instance.*/ > > #define DEFAULT_MAS_INSTANCE 0x00 > > > > +#define DEFAULT_PBAP_SUPPORTED_FEATURES 0x00000003 > > + > > #define MAP_MSG_TYPE_SMS_GSM 0x02 > > #define MAP_MSG_TYPE_SMS_CDMA 0x04 > > #define DEFAULT_MAS_MSG_TYPE (MAP_MSG_TYPE_SMS_GSM | > MAP_MSG_TYPE_SMS_CDMA) > > @@ -287,6 +289,7 @@ static sdp_record_t *create_pbap_record(uint8_t > > chan, const char *svc_name) sdp_list_t *seq; > > sdp_profile_desc_t profile[1]; > > uint8_t formats = 0x01; > > + uint8_t supft = DEFAULT_PBAP_SUPPORTED_FEATURES; > > sdp_record_t *record; > > uuid_t uuid; > > > > @@ -304,6 +307,9 @@ static sdp_record_t *create_pbap_record(uint8_t > > chan, const char *svc_name) sdp_attr_add_new(record, > > SDP_ATTR_SUPPORTED_REPOSITORIES, SDP_UINT8, &formats); > > > > + sdp_attr_add_new(record, > SDP_ATTR_PBAP_SUPPORTED_FEATURES, SDP_UINT32, > > + &supft); > > + > > sdp_list_free(seq, NULL); > > > > return record; > > -- > BR > Szymon Janc Regards, Gowtham Anandha Babu -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
