Re: [PATCH ] monitor/rfcomm: Fix byte ordering issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Gowtham,

On Fri, Dec 5, 2014 at 3:44 PM, Gowtham Anandha Babu
<gowtham.ab@xxxxxxxxxxx> wrote:
> The correct byte order for RFCOMM protocol is
> little endian.
> ---
>  monitor/rfcomm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c
> index fe3afb7..e8dfdb5 100644
> --- a/monitor/rfcomm.c
> +++ b/monitor/rfcomm.c
> @@ -218,7 +218,7 @@ static inline bool mcc_rpn(struct rfcomm_frame *rfcomm_frame, uint8_t indent)
>                 GET_RPN_RTCI(rpn.io), GET_RPN_RTCO(rpn.io), rpn.xon,
>                 rpn.xoff);
>
> -       if (!l2cap_frame_get_be16(frame, &rpn.pm))
> +       if (!l2cap_frame_get_le16(frame, &rpn.pm))
>                 return false;
>
>         print_field("%*cpm 0x%04x", indent, ' ', rpn.pm);
> @@ -267,7 +267,7 @@ static inline bool mcc_pn(struct rfcomm_frame *rfcomm_frame, uint8_t indent)
>         if (!l2cap_frame_get_u8(frame, &pn.ack_timer))
>                 return false;
>
> -       if (!l2cap_frame_get_be16(frame, &pn.mtu))
> +       if (!l2cap_frame_get_le16(frame, &pn.mtu))
>                 return false;
>
>         if (!l2cap_frame_get_u8(frame, &pn.max_retrans))
> --
> 1.9.1

Applied, thanks.


-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux