RE: [RFC] monitor: Fix RFCOMM parity type mask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrei,

> -----Original Message-----
> From: linux-bluetooth-owner@xxxxxxxxxxxxxxx [mailto:linux-bluetooth-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Andrei Emeltchenko
> Sent: Friday, December 05, 2014 3:18 PM
> To: linux-bluetooth@xxxxxxxxxxxxxxx
> Subject: [RFC] monitor: Fix RFCOMM parity type mask
> 
> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
> 
> ---
>  monitor/rfcomm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c index fe3afb7..71a2792
> 100644
> --- a/monitor/rfcomm.c
> +++ b/monitor/rfcomm.c
> @@ -67,7 +67,7 @@ static char *cr_str[] = {
>  #define GET_RPN_DB(parity)	(parity & 0x03)
>  #define GET_RPN_SB(parity)	((parity & 0x04) >> 2)
>  #define GET_RPN_PARITY(parity)	((parity & 0x08) >> 3)
> -#define GET_RPN_PTYPE(parity)	((parity & 0x03) >> 3)
> +#define GET_RPN_PTYPE(parity)	((parity & 0x10) >> 4)
>  #define GET_RPN_XIN(io)		(io & 0x01)
>  #define GET_RPN_XOUT(io)	((io & 0x02) >> 1)
>  #define GET_RPN_RTRI(io)	((io & 0x04) >> 2)
> --
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo
> info at  http://vger.kernel.org/majordomo-info.html


I missed it during the implementation. Anyway, the parity type bits are in
BIT5 and BIT6 as per the specification.
So it will be 0x30 instead of 0x10.

 Regards,
Gowtham Anandha Babu

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux